From: Kees Cook <kees@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Azeem Shaikh <azeemshaikh38@gmail.com>,
Alex Elder <elder@kernel.org>, Sumit Garg <sumit.garg@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
alx@kernel.org
Subject: Re: [PATCH] EISA: Increase length of device names
Date: Mon, 7 Apr 2025 09:49:04 -0700 [thread overview]
Message-ID: <202504070948.B71965DC7@keescook> (raw)
In-Reply-To: <3c6bc732-bd90-4a29-bcbc-f545b0ed79ad@riscstar.com>
On Sat, Mar 15, 2025 at 09:27:36AM -0500, Alex Elder wrote:
> On 3/10/25 5:24 PM, Kees Cook wrote:
> > GCC 15's -Wunterminated-string-initialization warned about truncated
> > name strings. Instead of marking them with the "nonstring" attribute[1],
> > increase their length to correctly include enough space for the
> > terminating NUL character, as they are used with %s format specifiers.
> >
> > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Azeem Shaikh <azeemshaikh38@gmail.com>
> > Cc: Alex Elder <elder@kernel.org>
>
> This was interesting, but based on the bug text I suspect you
> meant to address this to Alejandro Colomar, <alx@kernel.org>.
I think you got tagged because of the Reviewed-by on commit d69d80484598
("driver core: have match() callback in struct bus_type take a const *")
which touched include/linux/eisa.h.
> For what it's worth, it looks fine to me.
Thanks!
--
Kees Cook
prev parent reply other threads:[~2025-04-07 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 22:24 [PATCH] EISA: Increase length of device names Kees Cook
2025-03-15 14:27 ` Alex Elder
2025-03-15 16:02 ` Alejandro Colomar
2025-04-02 23:23 ` Maciej W. Rozycki
2025-04-07 17:12 ` Kees Cook
2025-04-07 16:49 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504070948.B71965DC7@keescook \
--to=kees@kernel.org \
--cc=alx@kernel.org \
--cc=azeemshaikh38@gmail.com \
--cc=elder@kernel.org \
--cc=elder@riscstar.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.garg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.