All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	netdev@vger.kernel.org, hkallweit1@gmail.com,
	davem@davemloft.net, pabeni@redhat.com
Subject: Re: [net PATCH 1/2] net: phy: Cleanup handling of recent changes to phy_lookup_setting
Date: Mon, 7 Apr 2025 10:01:38 -0700	[thread overview]
Message-ID: <20250407100138.160f5cb7@kernel.org> (raw)
In-Reply-To: <CAKgT0UeJvSSCybrqUwgfXxva6oBq0n9rxM=-97DQZQR1kbL8SQ@mail.gmail.com>

On Fri, 4 Apr 2025 09:18:30 -0700 Alexander Duyck wrote:
> > > Yep, this is pretty typical of SOHO switches, you use strapping to set
> > > the port, and it never changes, at least not without a soldering iron
> > > to take off/add resistors. There are also some SOHO switches which
> > > have a dedicated 'cpu port' and there is no configuration options at
> > > all. The CPU MAC must conform to what the switch MAC is doing.  
> 
> I don't think you guys understand my case well either. You seem to
> think I am more flexible than I actually am in this setup. While I do
> have the firmware I can ask about settings all it provides me with is
> fixed link info. I can't talk to the link partner on the other end as
> it is just configured for whatever the one mode is it has and there is
> no changing it. Now yes, it isn't physically locked down. However most
> of the silicon in the "fixed-link" configs likely aren't either until
> they are put in their embedded setups.

I understand this code the least of all of you, obviously, but FWIW
in my mind the datacenter use case is more like trying to feed
set_link_ksettings() from the EEPROM. Rather than a OS config script.
Maybe call it "stored link" ? Not sure how fruitful arguing whether 
the term "fixed-link" can be extended to cover this is going to be :S

  reply	other threads:[~2025-04-07 17:01 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 21:29 [net PATCH 0/2] Fixes for net/phy/phylink.c Alexander Duyck
2025-04-01 21:30 ` [net PATCH 1/2] net: phy: Cleanup handling of recent changes to phy_lookup_setting Alexander Duyck
2025-04-02  7:00   ` Maxime Chevallier
2025-04-02 14:21     ` Alexander H Duyck
2025-04-02 17:17       ` Jakub Kicinski
2025-04-02 17:30         ` Russell King (Oracle)
2025-04-02 22:37           ` Alexander Duyck
2025-04-03 14:55   ` Russell King (Oracle)
2025-04-03 15:29     ` Maxime Chevallier
2025-04-03 16:34       ` Andrew Lunn
2025-04-03 21:53         ` Alexander Duyck
2025-04-03 23:19           ` Russell King (Oracle)
2025-04-04 15:56             ` Alexander Duyck
2025-04-04 16:33               ` Andrew Lunn
2025-04-04 22:46                 ` Alexander Duyck
2025-04-05  9:43                   ` Russell King (Oracle)
2025-04-05 14:51                   ` Andrew Lunn
2025-04-05 20:41                     ` Alexander Duyck
2025-04-05 20:53                       ` Andrew Lunn
2025-04-05  9:10               ` Russell King (Oracle)
2025-04-05 15:43                 ` Andrew Lunn
2025-04-05 15:52                 ` Andrew Lunn
2025-04-05 16:19                   ` Alexander Duyck
2025-04-05 20:23                 ` Alexander Duyck
2025-04-03 23:26           ` Russell King (Oracle)
2025-04-04  1:46             ` Andrew Lunn
2025-04-04  7:16               ` Russell King (Oracle)
2025-04-04 16:18                 ` Alexander Duyck
2025-04-07 17:01                   ` Jakub Kicinski [this message]
2025-04-07 18:20                     ` Alexander Duyck
2025-04-07 19:34                       ` Andrew Lunn
2025-04-07 23:01                         ` Alexander Duyck
2025-04-01 21:30 ` [net PATCH 2/2] net: phylink: Set advertising based on phy_lookup_setting in ksettings_set Alexander Duyck
2025-04-02 18:02   ` Russell King (Oracle)
2025-04-02 22:34     ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407100138.160f5cb7@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexander.duyck@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.