From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4423C369A2 for ; Mon, 7 Apr 2025 15:23:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FC0410E4EF; Mon, 7 Apr 2025 15:23:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Cwx8K2hA"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 396A710E3EE; Mon, 7 Apr 2025 15:23:02 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9AF215C24F3; Mon, 7 Apr 2025 15:20:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FF1FC4CEE8; Mon, 7 Apr 2025 15:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744039381; bh=c/cHw962Afn9EFlsW0TCSyauMJFYlWb4TIDzbQnTmWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cwx8K2hAA/WItU/f3PVN0MjpeYPCVFg6ErCkXbtxM5JHrPuitd9N/LA34iAjk1ZV8 sd6BpD3IjjhRTW0TqkAYPFRZRKmoKKZ9zkVPosW+DMEQIoxLNK/lWnYPAj0ouNmBLs cWC/AfZ84uFY07DGjuW+MqHAR6nDl7gA6kJS8PPJJDDgY0ErNKvKXPX4SuN5wX+yJx w8bdd8Pwf03vO5RHZQSOhyNg3aFH4Fo0cL7Q5PT/NTXLGJFrf3AfjvdHRAiJO+Op8Q WBvK4POj2ni4qmSdK5QUMyucSUsR6vkT1dljWIEomlXLvEPb0ZPEvD3qqq2Nqka3wa bckAOm+EH+5Mg== From: Philipp Stanner To: Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Matthew Brost , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] drm/sched: Warn if pending list is not empty Date: Mon, 7 Apr 2025 17:22:38 +0200 Message-ID: <20250407152239.34429-5-phasta@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250407152239.34429-2-phasta@kernel.org> References: <20250407152239.34429-2-phasta@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Signed-off-by: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 6b72278c4b72..ae3152beca14 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -1465,6 +1465,10 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched) sched->ready = false; kfree(sched->sched_rq); sched->sched_rq = NULL; + + if (!list_empty(&sched->pending_list)) + dev_err(sched->dev, "%s: Tearing down scheduler while jobs are pending!\n", + __func__); } EXPORT_SYMBOL(drm_sched_fini); -- 2.48.1