From: Jason Gunthorpe <jgg@nvidia.com>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
zyjzyj2000@gmail.com, leon@kernel.org,
matsuda-daisuke@fujitsu.com,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] RDMA/rxe: Fix null pointer dereference in ODP MR check
Date: Mon, 7 Apr 2025 15:23:41 -0300 [thread overview]
Message-ID: <20250407182341.GA1771020@nvidia.com> (raw)
In-Reply-To: <20250402032657.1762800-1-lizhijian@fujitsu.com>
On Wed, Apr 02, 2025 at 11:26:57AM +0800, Li Zhijian wrote:
> The blktests/rnbd reported a null pointer dereference as following.
> Similar to the mxl5, introduce a is_odp_mr() to check if the odp
> is enabled in this mr.
>
> Workqueue: rxe_wq do_work [rdma_rxe]
> RIP: 0010:rxe_mr_copy+0x57/0x210 [rdma_rxe]
> Code: 7c 04 48 89 f3 48 89 d5 41 89 cf 45 89 c4 0f 84 dc 00 00 00 89 ca e8 f8 f8 ff ff 85 c0 0f 85 75 01 00 00 49 8b 86 f0 00 00 00 <f6> 40 28 02 0f 85 98 01 00 00 41 8b 46 78 41 8b 8e 10 01 00 00 8d
> RSP: 0018:ffffa0aac02cfcf8 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: ffff9079cd440024 RCX: 0000000000000000
> RDX: 000000000000003c RSI: ffff9079cd440060 RDI: ffff9079cd665600
> RBP: ffff9079c0e5e45a R08: 0000000000000000 R09: 0000000000000000
> R10: 000000003c000000 R11: 0000000000225510 R12: 0000000000000000
> R13: 0000000000000000 R14: ffff9079cd665600 R15: 000000000000003c
> FS: 0000000000000000(0000) GS:ffff907ccfa80000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000000000028 CR3: 0000000119498001 CR4: 00000000001726f0
> Call Trace:
> <TASK>
> ? __die_body+0x1e/0x60
> ? page_fault_oops+0x14f/0x4c0
> ? rxe_mr_copy+0x57/0x210 [rdma_rxe]
> ? search_bpf_extables+0x5f/0x80
> ? exc_page_fault+0x7e/0x180
> ? asm_exc_page_fault+0x26/0x30
> ? rxe_mr_copy+0x57/0x210 [rdma_rxe]
> ? rxe_mr_copy+0x48/0x210 [rdma_rxe]
> ? rxe_pool_get_index+0x50/0x90 [rdma_rxe]
> rxe_receiver+0x1d98/0x2530 [rdma_rxe]
> ? psi_task_switch+0x1ff/0x250
> ? finish_task_switch+0x92/0x2d0
> ? __schedule+0xbdf/0x17c0
> do_task+0x65/0x1e0 [rdma_rxe]
> process_scheduled_works+0xaa/0x3f0
> worker_thread+0x117/0x240
>
> Fixes: d03fb5c6599e ("RDMA/rxe: Allow registering MRs for On-Demand Paging")
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> Reviewed-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/infiniband/sw/rxe/rxe_loc.h | 6 ++++++
> drivers/infiniband/sw/rxe/rxe_mr.c | 4 ++--
> drivers/infiniband/sw/rxe/rxe_resp.c | 4 ++--
> 3 files changed, 10 insertions(+), 4 deletions(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2025-04-07 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 3:26 [PATCH] RDMA/rxe: Fix null pointer dereference in ODP MR check Li Zhijian
2025-04-02 5:11 ` Daisuke Matsuda (Fujitsu)
2025-04-02 8:58 ` Zhu Yanjun
2025-04-03 2:59 ` Zhijian Li (Fujitsu)
2025-04-03 13:33 ` Zhu Yanjun
2025-04-07 18:23 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407182341.GA1771020@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=matsuda-daisuke@fujitsu.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.