Re: [PATCH net-next v8 1/2] page_pool: Move pp_magic check into helper functions

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 07 Apr 2025 18:53:28 +0200 Toke Høiland-Jørgensen wrote:
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index b7f13f087954bdccfe1e263d39a59bfd1d738ab6..6f9ef1634f75701ae0be146add1ea2c11beb6e48 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -4248,4 +4248,25 @@ int arch_lock_shadow_stack_status(struct task_struct *t, unsigned long 

> +static inline bool page_pool_page_is_pp(struct page *page)
> +{
> +	return false;
> +}
> +#endif
> +
> +

extra empty line here

>  #endif /* _LINUX_MM_H */
> diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h
> index 36eb57d73abc6cfc601e700ca08be20fb8281055..31e6c5c6724b1cffbf5ad2535b3eaee5dec54d9d 100644
> --- a/include/net/page_pool/types.h
> +++ b/include/net/page_pool/types.h
> @@ -264,6 +264,7 @@ void page_pool_destroy(struct page_pool *pool);
>  void page_pool_use_xdp_mem(struct page_pool *pool, void (*disconnect)(void *),
>  			   const struct xdp_mem_info *mem);
>  void page_pool_put_netmem_bulk(netmem_ref *data, u32 count);
> +

and here

>  #else
>  static inline void page_pool_destroy(struct page_pool *pool)
>  {
-- 
pw-bot: cr