From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Allison Henderson <allison.henderson@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
rds-devel@oss.oracle.com
Subject: Re: [PATCH net-next] rds: rely on IB/core to determine if device is ODP capable
Date: Tue, 8 Apr 2025 09:23:38 -0300 [thread overview]
Message-ID: <20250408122338.GA1778492@nvidia.com> (raw)
In-Reply-To: <bfc8ffb7ea207ed90c777a4f61a8afe1badef212.1744109826.git.leonro@nvidia.com>
On Tue, Apr 08, 2025 at 02:04:55PM +0300, Leon Romanovsky wrote:
> diff --git a/net/rds/ib.c b/net/rds/ib.c
> index 9826fe7f9d00..c62aa2ff4963 100644
> --- a/net/rds/ib.c
> +++ b/net/rds/ib.c
> @@ -153,14 +153,6 @@ static int rds_ib_add_one(struct ib_device *device)
> rds_ibdev->max_wrs = device->attrs.max_qp_wr;
> rds_ibdev->max_sge = min(device->attrs.max_send_sge, RDS_IB_MAX_SGE);
>
> - rds_ibdev->odp_capable =
> - !!(device->attrs.kernel_cap_flags &
> - IBK_ON_DEMAND_PAGING) &&
> - !!(device->attrs.odp_caps.per_transport_caps.rc_odp_caps &
> - IB_ODP_SUPPORT_WRITE) &&
> - !!(device->attrs.odp_caps.per_transport_caps.rc_odp_caps &
> - IB_ODP_SUPPORT_READ);
This patch seems to drop the check for WRITE and READ support on the
ODP.
Jason
next prev parent reply other threads:[~2025-04-08 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 11:04 [PATCH net-next] rds: rely on IB/core to determine if device is ODP capable Leon Romanovsky
2025-04-08 12:23 ` Jason Gunthorpe [this message]
2025-04-08 12:34 ` Leon Romanovsky
2025-04-08 12:38 ` Jason Gunthorpe
2025-04-08 19:11 ` Leon Romanovsky
2025-04-09 0:54 ` Allison Henderson
2025-04-10 11:35 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408122338.GA1778492@nvidia.com \
--to=jgg@nvidia.com \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.