From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Boris Brezillon <bbrezillon@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: at91: at91sam9263: fix NAND chip selects
Date: Tue, 8 Apr 2025 16:36:10 +0200 [thread overview]
Message-ID: <20250408143610b360aba2@mail.local> (raw)
In-Reply-To: <20250402210446.5972-2-wsa+renesas@sang-engineering.com>
On 02/04/2025 23:04:46+0200, Wolfram Sang wrote:
> NAND did not work on my USB-A9263. I discovered that the offending
> commit converted the PIO bank for chip selects wrongly, so all A9263
> boards need to be fixed.
>
> Fixes: 1004a2977bdc ("ARM: dts: at91: Switch to the new NAND bindings")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +-
> arch/arm/boot/dts/microchip/tny_a9263.dts | 2 +-
> arch/arm/boot/dts/microchip/usb_a9263.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> index 471ea25296aa..93c5268a0845 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> @@ -152,7 +152,7 @@ nand_controller: nand-controller {
> nand@3 {
> reg = <0x3 0x0 0x800000>;
> rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
> - cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
> nand-bus-width = <8>;
> nand-ecc-mode = "soft";
> nand-on-flash-bbt;
> diff --git a/arch/arm/boot/dts/microchip/tny_a9263.dts b/arch/arm/boot/dts/microchip/tny_a9263.dts
> index 3dd48b3e06da..fd8244b56e05 100644
> --- a/arch/arm/boot/dts/microchip/tny_a9263.dts
> +++ b/arch/arm/boot/dts/microchip/tny_a9263.dts
> @@ -64,7 +64,7 @@ nand_controller: nand-controller {
> nand@3 {
> reg = <0x3 0x0 0x800000>;
> rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
> - cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
> nand-bus-width = <8>;
> nand-ecc-mode = "soft";
> nand-on-flash-bbt;
> diff --git a/arch/arm/boot/dts/microchip/usb_a9263.dts b/arch/arm/boot/dts/microchip/usb_a9263.dts
> index 60d7936dc562..ebaf198e1bc4 100644
> --- a/arch/arm/boot/dts/microchip/usb_a9263.dts
> +++ b/arch/arm/boot/dts/microchip/usb_a9263.dts
> @@ -84,7 +84,7 @@ nand_controller: nand-controller {
> nand@3 {
> reg = <0x3 0x0 0x800000>;
> rb-gpios = <&pioA 22 GPIO_ACTIVE_HIGH>;
> - cs-gpios = <&pioA 15 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&pioD 15 GPIO_ACTIVE_HIGH>;
> nand-bus-width = <8>;
> nand-ecc-mode = "soft";
> nand-on-flash-bbt;
> --
> 2.47.2
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-04-08 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 21:04 [PATCH] ARM: dts: at91: at91sam9263: fix NAND chip selects Wolfram Sang
2025-04-08 14:36 ` Alexandre Belloni [this message]
2025-04-11 14:32 ` Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408143610b360aba2@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.