From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
David Ahern <dsahern@kernel.org>,
"Neal Cardwell" <ncardwell@google.com>,
Willem de Bruijn <willemb@google.com>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Kuniyuki Iwashima" <kuni1840@gmail.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH v1 net-next 3/4] net: Unexport shared functions for DCCP.
Date: Tue, 8 Apr 2025 16:25:12 -0700 [thread overview]
Message-ID: <20250408162512.23a84b5e@kernel.org> (raw)
In-Reply-To: <20250407231823.95927-4-kuniyu@amazon.com>
On Mon, 7 Apr 2025 16:17:50 -0700 Kuniyuki Iwashima wrote:
> DCCP was removed, so many inet functions no longer need to
> be exported.
>
> Let's unexport or use EXPORT_IPV6_MOD() for such functions.
>
> sk_free_unlock_clone() is inlined in sk_clone_lock() as it's
> the only caller.
netfilter wants inet_twsk_put
ERROR: modpost: "inet_twsk_put" [net/ipv4/netfilter/nf_tproxy_ipv4.ko] undefined!
ERROR: modpost: "inet_twsk_put" [net/ipv6/netfilter/nf_tproxy_ipv6.ko] undefined!
allmodconfig builds seems to miss it :(
--
pw-bot: cr
next prev parent reply other threads:[~2025-04-08 23:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 23:17 [PATCH v1 net-next 0/4] net: Retire DCCP Kuniyuki Iwashima
2025-04-07 23:17 ` [PATCH v1 net-next 1/4] selftest: net: Remove DCCP bits Kuniyuki Iwashima
2025-04-07 23:17 ` [PATCH v1 net-next 2/4] net: Retire DCCP Kuniyuki Iwashima
2025-04-08 1:34 ` Paul Moore
2025-04-08 5:22 ` Christian Göttsche
2025-04-08 8:12 ` Paul Moore
2025-04-08 16:28 ` Casey Schaufler
2025-04-08 16:37 ` Pablo Neira Ayuso
2025-04-08 17:31 ` Kuniyuki Iwashima
2025-04-07 23:17 ` [PATCH v1 net-next 3/4] net: Unexport shared functions for DCCP Kuniyuki Iwashima
2025-04-08 23:25 ` Jakub Kicinski [this message]
2025-04-08 23:53 ` Kuniyuki Iwashima
2025-04-07 23:17 ` [PATCH v1 net-next 4/4] tcp: Rename tcp_or_dccp_get_hashinfo() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408162512.23a84b5e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jmorris@namei.org \
--cc=kadlec@netfilter.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.