From: Simon Horman <horms@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com, kuba@kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, suhui@nfschina.com, sanman.p211993@gmail.com,
vadim.fedorenko@linux.dev, kalesh-anakkur.purayil@broadcom.com,
kernel-team@meta.com
Subject: Re: [PATCH net-next 1/5] eth: fbnic: add locking support for hw stats
Date: Tue, 8 Apr 2025 17:40:38 +0100 [thread overview]
Message-ID: <20250408164038.GA395307@horms.kernel.org> (raw)
In-Reply-To: <20250407172151.3802893-2-mohsin.bashr@gmail.com>
On Mon, Apr 07, 2025 at 10:21:47AM -0700, Mohsin Bashir wrote:
> This patch adds lock protection for the hardware statistics for fbnic.
> The hardware statistics access via ndo_get_stats64 is not protected by
> the rtnl_lock(). Since these stats can be accessed from different places
> in the code such as service task, ethtool, Q-API, and net_device_ops, a
> lock-less approach can lead to races.
>
> Note that this patch is not a fix rather, just a prep for the subsequent
> changes in this series.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-04-08 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 17:21 [PATCH net-next 0/5] eth: fbnic: extend hardware stats coverage Mohsin Bashir
2025-04-07 17:21 ` [PATCH net-next 1/5] eth: fbnic: add locking support for hw stats Mohsin Bashir
2025-04-08 16:40 ` Simon Horman [this message]
2025-04-07 17:21 ` [PATCH net-next 2/5] eth: fbnic: add coverage for hw queue stats Mohsin Bashir
2025-04-08 16:40 ` Simon Horman
2025-04-09 7:32 ` Paolo Abeni
2025-04-10 0:18 ` Mohsin Bashir
2025-04-07 17:21 ` [PATCH net-next 3/5] eth: fbnic: add coverage for RXB stats Mohsin Bashir
2025-04-08 16:42 ` Simon Horman
2025-04-07 17:21 ` [PATCH net-next 4/5] eth: fbnic: add support for TMI stats Mohsin Bashir
2025-04-08 16:43 ` Simon Horman
2025-04-07 17:21 ` [PATCH net-next 5/5] eth: fbnic: add support for TTI HW stats Mohsin Bashir
2025-04-08 16:43 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408164038.GA395307@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanman.p211993@gmail.com \
--cc=suhui@nfschina.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.