From: Petr Vorel <pvorel@suse.cz>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: lufei <lufei@uniontech.com>,
viro@zeniv.linux.org.uk, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2] unshare_test: set nr_open using soft limit
Date: Wed, 9 Apr 2025 07:56:56 +0200 [thread overview]
Message-ID: <20250409055656.GA231133@pevik> (raw)
In-Reply-To: <8aa78b76-b9f9-4d23-a009-97b26aefcf33@linuxfoundation.org>
> On 3/31/25 19:55, lufei wrote:
> > Set maximum file descriptor number limit by rlimit.rlim_max than
> > nr_open(hard limit). Hard limit may cause dup2 fail.
> > Signed-off-by: lufei <lufei@uniontech.com>
> Petr, Al,
> Okay to take this patch?
LGTM, hopefully I haven't overlook anything.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
FYI Cyril Hrubis suggested a different approach (for LTP tests which is based on
this Al's test):
https://lore.kernel.org/ltp/Z-u7yYJpTBG8Hi6A@yuki.lan/
https://lore.kernel.org/ltp/Z-vwYZxLms8juTjX@yuki.lan/
filedescriptor that is >= 64 and set the nr_open to 64.
That would help to avoid using /proc/sys/fs/nr_open.
Kind regards,
Petr
> thanks,
> -- Shuah
next prev parent reply other threads:[~2025-04-09 5:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 1:55 [PATCH v2] unshare_test: set nr_open using soft limit lufei
2025-04-08 23:42 ` Shuah Khan
2025-04-09 5:56 ` Petr Vorel [this message]
2025-04-09 21:30 ` Shuah Khan
2025-04-10 2:05 ` Lu Fei
2025-04-14 2:17 ` [PATCH v3] selftests:core: unshare_test: using bits_per_long instead of nr_open+64 lufei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409055656.GA231133@pevik \
--to=pvorel@suse.cz \
--cc=linux-kselftest@vger.kernel.org \
--cc=lufei@uniontech.com \
--cc=skhan@linuxfoundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.