From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 390D82690FF; Wed, 9 Apr 2025 14:38:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744209517; cv=none; b=JXamGlmCipfNqiB3Utjdx87wBvHqlAyFPX5VlUwPKAbBJh8syD4J+/VvY9edWyGHjW0h/OWLvuarHbj2rxwssEB4dbB7MyhLTjV0jyXbUSb9BFlI35lzOHCJ3/I6X9SKsbx3nD7i+suglYtg1a5KzPVOQDZLv42Cwim701SyIpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744209517; c=relaxed/simple; bh=bZ9LqXFL20jiPKhVHCikZHr3AT6FsxsF+d8oFILNqJk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pCf4CFy9BS040dajknTNt79RYFfB9vc/IGZLObsjR+v+GID9uIKL/NTETGvnKOUOYC7p16KVDQLU9RlZmRCuqDqWtPFCHcBFftbj9UR5DTLf0q0GtjdwjNzv4EzBY9TEe43JrncjXnxA+ojMzIvllaRzTQQy1tk6XJaI9zlWan8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VppNnAd2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VppNnAd2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38FF3C4CEE7; Wed, 9 Apr 2025 14:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744209516; bh=bZ9LqXFL20jiPKhVHCikZHr3AT6FsxsF+d8oFILNqJk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VppNnAd2YISS5KOAan+Dz+7uk/id2F66sciDMXE5//+ld5vvD0IH5Jhjhmmyph8yh UFHMRrKBtnrhMwKSczQgKpiTvLPlRxeePIfiF8dKtZ5m1NvYewQtSkF6V6BMXJMbSO Qt6Ht+kiFzebGT9sy+YOkK5QmwWRoWjRkkznuL03j/eFFw/6oVn97lyeNdlXZuPwON cx6Khz11C11moVxdDI+euyuTEiBMFuMUl9eyWu5FpFWPVmqhNJ6+LkIiNeA1VudRwM TvXpS5EmPUTsVloDj9DR2d8z4q6xQa/Wrb+9aMYNmbSxNKJxqI7m2iQnY8Ni2u31Yn xttd+aPjUw+Vw== Date: Wed, 9 Apr 2025 07:38:35 -0700 From: Jakub Kicinski To: "Jagielski, Jedrzej" Cc: "Nguyen, Anthony L" , "davem@davemloft.net" , "pabeni@redhat.com" , "Dumazet, Eric" , "andrew+netdev@lunn.ch" , "netdev@vger.kernel.org" , "Kitszel, Przemyslaw" , "jiri@resnulli.us" , "horms@kernel.org" , "corbet@lwn.net" , "linux-doc@vger.kernel.org" , "Polchlopek, Mateusz" , "R, Bharath" , "Mrozowicz, SlawomirX" , "Kwapulinski, Piotr" Subject: Re: [PATCH net-next 10/15] ixgbe: extend .info_get with() stored versions Message-ID: <20250409073835.5d0e4018@kernel.org> In-Reply-To: References: <20250407215122.609521-1-anthony.l.nguyen@intel.com> <20250407215122.609521-11-anthony.l.nguyen@intel.com> <20250408193124.37f37f7c@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 9 Apr 2025 10:50:34 +0000 Jagielski, Jedrzej wrote: > >Just to be crystal clear -- could you share the outputs for dev info: > > - before update > > - after update, before reboot/reload > > - after update, after activation (/reboot/reload) > >? > > OK so this looks this way: Not terrible, but FWIW my expectation (and how we use it at Meta [1]) is that stored will always be present. If there is no update pending it will simply be equal to running. Otherwise it's unclear whether we're missing stored because it's not supported or because there is no pending update. But I guess it's not a huge deal if for some reason you can't achieve this behavior, just make sure to document it in the driver devlink doc. 1: https://docs.kernel.org/networking/devlink/devlink-flash.html#firmware-version-management