From: Stefano Brivio <sbrivio@redhat.com>
To: sontu mazumdar <sontu21@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf 3/3] selftests: netfilter: add test case for recent mismatch bug
Date: Wed, 9 Apr 2025 12:13:00 +0200 [thread overview]
Message-ID: <20250409121300.6032c69a@elisabeth> (raw)
In-Reply-To: <CANgxkqxfxzJdE2h1R=boQkAFQB=35EFYQ5fQ734nvaciSyJpow@mail.gmail.com>
On Wed, 9 Apr 2025 15:21:33 +0530
sontu mazumdar <sontu21@gmail.com> wrote:
> Florian, do we have the same test for every bit in the ipv6 address
> both matching/unmatching ? If not, would it be possible to add this to
> confirm that we are matching all the bits in the ipv6 address.
The equivalent testing, in more detail than that, is implemented by the
patch (under review) at:
https://lore.kernel.org/all/20250407174048.21272-4-fw@strlen.de/
You can add more tests on top on the new one in nft_concat_range.sh,
but it's not doable to test every single bit, because there are 2 ^ 128
possible IPv6 addresses. I guess you could add a test looping on bytes
or groups of 16 bits.
> Also, a general question, where is this netfilter code maintained ? I
> found this github where the code is present "GitHub - torvalds/linux:
> Linux kernel source tree" but couldn't see this fix in Pull request.
netfilter doesn't use GitHub. See:
https://www.netfilter.org/projects/nftables/index.html#git
--
Stefano
prev parent reply other threads:[~2025-04-09 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 6:20 [PATCH nf 0/3] nft_set_pipapo: fix incorrect avx2 match of 5th field octet Florian Westphal
2025-04-04 6:20 ` [PATCH nf 1/3] nft_set_pipapo: add avx register usage tracking for NET_DEBUG builds Florian Westphal
2025-04-04 10:40 ` Stefano Brivio
2025-04-04 11:42 ` Florian Westphal
2025-04-04 6:20 ` [PATCH nf 2/3] nft_set_pipapo: fix incorrect avx2 match of 5th field octet Florian Westphal
2025-04-04 8:34 ` Stefano Brivio
2025-04-04 6:20 ` [PATCH nf 3/3] selftests: netfilter: add test case for recent mismatch bug Florian Westphal
2025-04-04 11:51 ` Stefano Brivio
2025-04-09 9:51 ` sontu mazumdar
2025-04-09 10:13 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409121300.6032c69a@elisabeth \
--to=sbrivio@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=sontu21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.