From: Simon Horman <horms@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: andrew+netdev@lunn.ch, brett.creeley@amd.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, michal.swiatkowski@linux.intel.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net 6/6] pds_core: make wait_context part of q_info
Date: Wed, 9 Apr 2025 18:06:30 +0100 [thread overview]
Message-ID: <20250409170630.GN395307@horms.kernel.org> (raw)
In-Reply-To: <20250407225113.51850-7-shannon.nelson@amd.com>
On Mon, Apr 07, 2025 at 03:51:13PM -0700, Shannon Nelson wrote:
> Make the wait_context a full part of the q_info struct rather
> than a stack variable that goes away after pdsc_adminq_post()
> is done so that the context is still available after the wait
> loop has given up.
>
> There was a case where a slow development firmware caused
> the adminq request to time out, but then later the FW finally
> finished the request and sent the interrupt. The handler tried
> to complete_all() the completion context that had been created
> on the stack in pdsc_adminq_post() but no longer existed.
> This caused bad pointer usage, kernel crashes, and much wailing
> and gnashing of teeth.
>
> Fixes: 01ba61b55b20 ("pds_core: Add adminq processing and commands")
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2025-04-09 17:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 22:51 [PATCH net 0/6] pds_core: updates and fixes Shannon Nelson
2025-04-07 22:51 ` [PATCH net 1/6] pds_core: Prevent possible adminq overflow/stuck condition Shannon Nelson
2025-04-09 9:37 ` Simon Horman
2025-04-09 23:32 ` Nelson, Shannon
2025-04-11 18:59 ` Simon Horman
2025-04-07 22:51 ` [PATCH net 2/6] pds_core: remove extra name description Shannon Nelson
2025-04-09 9:41 ` Simon Horman
2025-04-07 22:51 ` [PATCH net 3/6] pds_core: handle unsupported PDS_CORE_CMD_FW_CONTROL result Shannon Nelson
2025-04-09 16:34 ` Simon Horman
2025-04-09 23:35 ` Nelson, Shannon
2025-04-07 22:51 ` [PATCH net 4/6] pds_core: Remove unnecessary check in pds_client_adminq_cmd() Shannon Nelson
2025-04-09 17:07 ` Simon Horman
2025-04-07 22:51 ` [PATCH net 5/6] pds_core: smaller adminq poll starting interval Shannon Nelson
2025-04-09 16:50 ` Simon Horman
2025-04-09 23:28 ` Nelson, Shannon
2025-04-07 22:51 ` [PATCH net 6/6] pds_core: make wait_context part of q_info Shannon Nelson
2025-04-09 17:06 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409170630.GN395307@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.