From: kernel test robot <lkp@intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-acpi@vger.kernel.org, devel@acpica.org,
linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: [rafael-pm:bleeding-edge 46/52] drivers/pinctrl/pinctrl-amd.c:1213:26: error: use of undeclared identifier 'pinctrl_amd_s2idle_dev_ops'
Date: Thu, 10 Apr 2025 04:36:55 +0800 [thread overview]
Message-ID: <202504100420.88UPkUTU-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: 089d4e79e2c932faef79e0061cb874000f755009
commit: 179db1909c5c4b5300cce626507b0f843f7d2cc2 [46/52] pinctrl: amd: Add an LPS0 check() callback
config: x86_64-buildonly-randconfig-001-20250409 (https://download.01.org/0day-ci/archive/20250410/202504100420.88UPkUTU-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250410/202504100420.88UPkUTU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504100420.88UPkUTU-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/pinctrl/pinctrl-amd.c:1213:26: error: use of undeclared identifier 'pinctrl_amd_s2idle_dev_ops'
1213 | acpi_register_lps0_dev(&pinctrl_amd_s2idle_dev_ops);
| ^
drivers/pinctrl/pinctrl-amd.c:1234:28: error: use of undeclared identifier 'pinctrl_amd_s2idle_dev_ops'
1234 | acpi_unregister_lps0_dev(&pinctrl_amd_s2idle_dev_ops);
| ^
2 errors generated.
vim +/pinctrl_amd_s2idle_dev_ops +1213 drivers/pinctrl/pinctrl-amd.c
1153
1154 gpio_dev->pdev = pdev;
1155 gpio_dev->gc.get_direction = amd_gpio_get_direction;
1156 gpio_dev->gc.direction_input = amd_gpio_direction_input;
1157 gpio_dev->gc.direction_output = amd_gpio_direction_output;
1158 gpio_dev->gc.get = amd_gpio_get_value;
1159 gpio_dev->gc.set = amd_gpio_set_value;
1160 gpio_dev->gc.set_config = amd_gpio_set_config;
1161 gpio_dev->gc.dbg_show = amd_gpio_dbg_show;
1162
1163 gpio_dev->gc.base = -1;
1164 gpio_dev->gc.label = pdev->name;
1165 gpio_dev->gc.owner = THIS_MODULE;
1166 gpio_dev->gc.parent = &pdev->dev;
1167 gpio_dev->gc.ngpio = resource_size(res) / 4;
1168
1169 gpio_dev->hwbank_num = gpio_dev->gc.ngpio / 64;
1170 gpio_dev->groups = kerncz_groups;
1171 gpio_dev->ngroups = ARRAY_SIZE(kerncz_groups);
1172
1173 amd_pinctrl_desc.name = dev_name(&pdev->dev);
1174 amd_get_iomux_res(gpio_dev);
1175 gpio_dev->pctrl = devm_pinctrl_register(&pdev->dev, &amd_pinctrl_desc,
1176 gpio_dev);
1177 if (IS_ERR(gpio_dev->pctrl)) {
1178 dev_err(&pdev->dev, "Couldn't register pinctrl driver\n");
1179 return PTR_ERR(gpio_dev->pctrl);
1180 }
1181
1182 /* Disable and mask interrupts */
1183 amd_gpio_irq_init(gpio_dev);
1184
1185 girq = &gpio_dev->gc.irq;
1186 gpio_irq_chip_set_chip(girq, &amd_gpio_irqchip);
1187 /* This will let us handle the parent IRQ in the driver */
1188 girq->parent_handler = NULL;
1189 girq->num_parents = 0;
1190 girq->parents = NULL;
1191 girq->default_type = IRQ_TYPE_NONE;
1192 girq->handler = handle_simple_irq;
1193
1194 ret = gpiochip_add_data(&gpio_dev->gc, gpio_dev);
1195 if (ret)
1196 return ret;
1197
1198 ret = gpiochip_add_pin_range(&gpio_dev->gc, dev_name(&pdev->dev),
1199 0, 0, gpio_dev->gc.ngpio);
1200 if (ret) {
1201 dev_err(&pdev->dev, "Failed to add pin range\n");
1202 goto out2;
1203 }
1204
1205 ret = devm_request_irq(&pdev->dev, gpio_dev->irq, amd_gpio_irq_handler,
1206 IRQF_SHARED | IRQF_COND_ONESHOT, KBUILD_MODNAME, gpio_dev);
1207 if (ret)
1208 goto out2;
1209
1210 platform_set_drvdata(pdev, gpio_dev);
1211 acpi_register_wakeup_handler(gpio_dev->irq, amd_gpio_check_wake, gpio_dev);
1212 #ifdef CONFIG_ACPI
> 1213 acpi_register_lps0_dev(&pinctrl_amd_s2idle_dev_ops);
1214 #endif
1215
1216 dev_dbg(&pdev->dev, "amd gpio driver loaded\n");
1217 return ret;
1218
1219 out2:
1220 gpiochip_remove(&gpio_dev->gc);
1221
1222 return ret;
1223 }
1224
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-04-09 20:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504100420.88UPkUTU-lkp@intel.com \
--to=lkp@intel.com \
--cc=devel@acpica.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mario.limonciello@amd.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.