From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4859C369A4 for ; Thu, 10 Apr 2025 08:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vyRnA4Q+yFbS2ZBT7zMPT+jHN8phVJhU2QuGyNS6f34=; b=DyAGU207m3qGVkwiP8zcWqkgNS Sd3nVCc2o0HoS1C7l52k7ucC6kr6KpHbo590stw1OY16fLcPJSqa4cwRW2BLfiefSvnkSAoW8jwWV oCeR7poNLpw+rg8FCil+pV4RuZ5CW2Zt1tlGp2e5me/AiiCRojbpT6vJvU6yrN7s59h5CwqiyiXen CtCPiW9hnHwVEww9XYkuxZHiRDRIYsP1AJSZ4VkFpQReUm5lwg2RjezgXUPiyy7c0vAuaVIATJV7X MYkdAtUOJPA89zBnDsEN5+gmP4+UyfBrGusX6Us8ahpmhNm2sPZBEDw8ZtWij3e8BqCAieBApoeG5 2UooBrRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2nV1-00000009n6X-1zDW; Thu, 10 Apr 2025 08:43:03 +0000 Received: from mgamail.intel.com ([198.175.65.20]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2lzk-00000009TPp-1232; Thu, 10 Apr 2025 07:06:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744268800; x=1775804800; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eVtQY8JBtI7OBFxIa1E1PA3pS0GE/8DYWFULSp6JaHg=; b=SWy+MEIxIKFI7gK7TTRI0dl9vEhB5kZYtSvbIx1zTCCFbwdUkRDmDNLW 9VkPKNBtuePT0FPjCdKwCutxVx3symAarTYa32DY3Kkf7s2DvzG9kUTuz hcLZ5YNpfhqm/GHUNV1RpnE/x/4LzwWGYnRidLNOY3Z0a/JQr2ZTyWW+2 PC4Ri7bYGA/1jRIWRW++ytGTJ0EEuuZLae963uSlzyEL5I5DHA051GGXn Zt47L/ZoAX6H9bKA4ENBD5X2kwkRu9uHIgV7eLTjQM6dzA/5KJb8OziYu U6nx3km/e3BhnrEFt9pEKitqgIsgvcWQentYvcuE07cZpgRj+0k8EmX4O g==; X-CSE-ConnectionGUID: V27z1nB+STSlsqswaxjU4A== X-CSE-MsgGUID: xBncpXWARnSHc5Az+xsx/A== X-IronPort-AV: E=McAfee;i="6700,10204,11399"; a="45484786" X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="45484786" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 00:06:39 -0700 X-CSE-ConnectionGUID: kVTH2jZVTbeS/zX/rcXnvA== X-CSE-MsgGUID: BorZ3DaiT8GsjoUcY7tKvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="128791501" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 00:06:36 -0700 Received: from punajuuri.localdomain (punajuuri.localdomain [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id AAD2D11FA2F; Thu, 10 Apr 2025 10:06:33 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.96) (envelope-from ) id 1u2lzd-00FQT7-28; Thu, 10 Apr 2025 10:06:33 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo From: Sakari Ailus To: linux-crypto@vger.kernel.org Cc: Olivia Mackall , Herbert Xu , Nicolas Ferre , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Avi Fishman , Tomer Maimon , Tali Perry , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org Subject: [PATCH 1/3] hwrng: atmel - Add a local variable for struct device pointer Date: Thu, 10 Apr 2025 10:06:21 +0300 Message-Id: <20250410070623.3676647-2-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250410070623.3676647-1-sakari.ailus@linux.intel.com> References: <20250410070623.3676647-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_000640_320045_E7038501 X-CRM114-Status: GOOD ( 11.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add a local variable for a struct device pointer instead of obtaining the hwrng priv field and casting it as a struct device pointer whenever it's needed. Signed-off-by: Sakari Ailus --- drivers/char/hw_random/atmel-rng.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c index 143406bc6939..5192c39ebaeb 100644 --- a/drivers/char/hw_random/atmel-rng.c +++ b/drivers/char/hw_random/atmel-rng.c @@ -56,12 +56,13 @@ static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max, bool wait) { struct atmel_trng *trng = container_of(rng, struct atmel_trng, rng); + struct device *dev = (struct device *)trng->rng.priv; u32 *data = buf; int ret; - ret = pm_runtime_get_sync((struct device *)trng->rng.priv); + ret = pm_runtime_get_sync(dev); if (ret < 0) { - pm_runtime_put_sync((struct device *)trng->rng.priv); + pm_runtime_put_sync(dev); return ret; } @@ -79,8 +80,8 @@ static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max, ret = 4; out: - pm_runtime_mark_last_busy((struct device *)trng->rng.priv); - pm_runtime_put_sync_autosuspend((struct device *)trng->rng.priv); + pm_runtime_mark_last_busy(dev); + pm_runtime_put_sync_autosuspend(dev); return ret; } -- 2.39.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDD72C3601E for ; Thu, 10 Apr 2025 07:08:11 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZY9rD6HX8z3dV9 for ; Thu, 10 Apr 2025 17:07:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1744268870; cv=none; b=WtIdlsGwvy53p8R3Nyu05RdSM2hj7tRDGgYNbziyBwCbCx3+sKvgb1o9G9wD8/uVccM3PAXdwu6oGVCPzSkVGul/F9uE1r6IYxNNLFZOKlhHTFv5pJkN7zcYNdCjzIVTK4BvGJ/xosgIl4O4x5A5ePGYI/nintPi3TKHD/M+qWvXXjArNuQ/IQPAx0i4OEcGKs+VFz0ikMPVGBzwsB8Tjy6vN5P3w8APC4Y+UpSPReBfhWldnkNpo5EIp4NmTbWH1OqtwAW3OGQZ4uZj5D6gwCs9oQmEbrwiqjO/F+iqxzcTTqJejHEZd0W3jza3EbzTQleYjp8RmaGjKo/8U6J5hQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1744268870; c=relaxed/relaxed; bh=vyRnA4Q+yFbS2ZBT7zMPT+jHN8phVJhU2QuGyNS6f34=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QUTqcbR2I7wbTTgt5j1mIup0/Eo4YVs2BoumIIX9Zh66a4vU+wLVicF/H0AYkZi8OQC3k4lPFNyY2dTNQAPxDNlNKBfB1vYGlZnzAWYVpyXG/nY+eJidj01EiAnXo+2yBfPnJo7PI7Gc+htXMoH56K9qAtfgTzgWu9k15g9vUViMgTJBTEsq5osRt4bY3HCfzOVjM9hBRRGY2JqoywQUSaRaNIaDVjQPRpduuq9U1z66yf8qU3PmxHA8P2ddkluJwrDrLsFt84CR3XTQ2HXS7GtaBl5+BRSfJzmQEeo49xBHMNzh05z+w/Nub8DcW+6+QZjkNyHayc8aWmdid2iH4w== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=RCmryPUs; dkim-atps=neutral; spf=none (client-ip=198.175.65.20; helo=mgamail.intel.com; envelope-from=sakari.ailus@linux.intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=RCmryPUs; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=198.175.65.20; helo=mgamail.intel.com; envelope-from=sakari.ailus@linux.intel.com; receiver=lists.ozlabs.org) X-Greylist: delayed 64 seconds by postgrey-1.37 at boromir; Thu, 10 Apr 2025 17:07:48 AEST Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZY9r40CMpz2ySc for ; Thu, 10 Apr 2025 17:07:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744268868; x=1775804868; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eVtQY8JBtI7OBFxIa1E1PA3pS0GE/8DYWFULSp6JaHg=; b=RCmryPUs22LVMoTr4+huvoDBSzgtYAuFSgFn76LS4yl89b/IB5X9TGDj qJJhOpDAVd9mdmIn0LFvQ2ZQ36DNztjjDf+Zq5kplzI7oxNgI7KVPzcoL YYQRik8YUrAYu8bJHCzXWNiUWLGnUnHYTt1GZQQh5616Md6KTdRTJWWCu zky+dZp4RAbalXyEKFaEAN84s5od4fXF/Y2IlcUFanRnUQPGI872L36bU hoJERSf6Ym3Z2ntD7UqFCdZqP7HTVsLOjUjdugzuMzRBiUrqa+nc2bmsr gxq8y51TWJVUSkI+RSBUIJPK8qxCoePKU63cqZUoQDtDjD4uNdWpnyn0U w==; X-CSE-ConnectionGUID: ffzuthswT6ysG73CAQX0NA== X-CSE-MsgGUID: ockwFiNmT9qyk6/dsVaPOA== X-IronPort-AV: E=McAfee;i="6700,10204,11399"; a="45484788" X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="45484788" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 00:06:39 -0700 X-CSE-ConnectionGUID: kVTH2jZVTbeS/zX/rcXnvA== X-CSE-MsgGUID: BorZ3DaiT8GsjoUcY7tKvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="128791501" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 00:06:36 -0700 Received: from punajuuri.localdomain (punajuuri.localdomain [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id AAD2D11FA2F; Thu, 10 Apr 2025 10:06:33 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.96) (envelope-from ) id 1u2lzd-00FQT7-28; Thu, 10 Apr 2025 10:06:33 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo From: Sakari Ailus To: linux-crypto@vger.kernel.org Subject: [PATCH 1/3] hwrng: atmel - Add a local variable for struct device pointer Date: Thu, 10 Apr 2025 10:06:21 +0300 Message-Id: <20250410070623.3676647-2-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250410070623.3676647-1-sakari.ailus@linux.intel.com> References: <20250410070623.3676647-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Avi Fishman , openbmc@lists.ozlabs.org, Sean Wang , Tomer Maimon , Nicolas Ferre , Tali Perry , Matthias Brugger , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Olivia Mackall , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Add a local variable for a struct device pointer instead of obtaining the hwrng priv field and casting it as a struct device pointer whenever it's needed. Signed-off-by: Sakari Ailus --- drivers/char/hw_random/atmel-rng.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c index 143406bc6939..5192c39ebaeb 100644 --- a/drivers/char/hw_random/atmel-rng.c +++ b/drivers/char/hw_random/atmel-rng.c @@ -56,12 +56,13 @@ static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max, bool wait) { struct atmel_trng *trng = container_of(rng, struct atmel_trng, rng); + struct device *dev = (struct device *)trng->rng.priv; u32 *data = buf; int ret; - ret = pm_runtime_get_sync((struct device *)trng->rng.priv); + ret = pm_runtime_get_sync(dev); if (ret < 0) { - pm_runtime_put_sync((struct device *)trng->rng.priv); + pm_runtime_put_sync(dev); return ret; } @@ -79,8 +80,8 @@ static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max, ret = 4; out: - pm_runtime_mark_last_busy((struct device *)trng->rng.priv); - pm_runtime_put_sync_autosuspend((struct device *)trng->rng.priv); + pm_runtime_mark_last_busy(dev); + pm_runtime_put_sync_autosuspend(dev); return ret; } -- 2.39.5