From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2B0DC369A2 for ; Thu, 10 Apr 2025 07:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6DooyLKKYj3wKO7vJaSrsdZC2t9Wx01KgJ5YQqX5GS4=; b=KofB9u7Y6adnEsfGA0dQRSR0qh hNqCdcV3ci0kjxcqd95QisD6jAOpL1muiAnZfjr3np/loe6i6Mst1N1eC0O994m96RqAjw64vcOHW tdd9d1dq63naiLjHt2is70pJJjI4V6S3C2WdBGdH44TBtmezS2SW5D2ZBjt0qM0MQf1MVCojbw7CQ myNEX+KuVTvTU/+KgTu07dlQpwXbt40ndiYtRkHePvGHcKyxkyTU4Uyz3vnitMuWcCAcCDuQqg1YC btKd53YJiBXx4W9q/zXgKmFhY8g1q+ZXQlYQAkbypXhP1VGMKc27OsK9escqDhuy6cRcT2W3SU3qc ZTI7ihqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2mbX-00000009cAr-0tW0; Thu, 10 Apr 2025 07:45:43 +0000 Received: from mgamail.intel.com ([198.175.65.20]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2lzn-00000009TQV-1BuE; Thu, 10 Apr 2025 07:06:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744268803; x=1775804803; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eTuV2CyB5vjAJ0CZ1BcbW4eb89Fsn/ZCIyYBD5yo6Ow=; b=YaK6mTkxeFIznD1IS58l51Y2krecFKZcNKwVGZ6BV+QBTRMLUgzxz0fc 3xJblumxzt7jPmD3PezAEllZGEy/08yZEOgRKYEQU8FzRXlNVzlTv6/gO nEJYT4FwaaH1BOYNRBZu4Wr3vk0geKuOJSWU72zyphh/lJl4qIbKQcn8i YkHjP2lwtI0DXqfi/0RBysp9SHA5H6o0/LLf7EUex19pGOcVD2MEzccBI BhfXbAwSruWnnhkvkB4cwpB6W+EycKbOTP/Fx6YgNL6tTQ++reEjFFUdr GV558wJFv5zEQOv5L/GyMTO6r+xBiaHrsYyUBfq/n/jDlEVHLTcLBaeOL w==; X-CSE-ConnectionGUID: nVumitD0TdO3auYsD/LwJA== X-CSE-MsgGUID: giUP06k1THCtMIiL+/y53A== X-IronPort-AV: E=McAfee;i="6700,10204,11399"; a="45484815" X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="45484815" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 00:06:40 -0700 X-CSE-ConnectionGUID: /9qgZoukRT2V3k+E473utg== X-CSE-MsgGUID: eCd3L+qyRjqOTOU2EOJUdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="128791505" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 00:06:36 -0700 Received: from punajuuri.localdomain (punajuuri.localdomain [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id B0BBE1203B9; Thu, 10 Apr 2025 10:06:33 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.96) (envelope-from ) id 1u2lzd-00FQTF-2I; Thu, 10 Apr 2025 10:06:33 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo From: Sakari Ailus To: linux-crypto@vger.kernel.org Cc: Olivia Mackall , Herbert Xu , Nicolas Ferre , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Avi Fishman , Tomer Maimon , Tali Perry , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org Subject: [PATCH 3/3] hwrng: npcm - Add a local variable for struct device pointer Date: Thu, 10 Apr 2025 10:06:23 +0300 Message-Id: <20250410070623.3676647-4-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250410070623.3676647-1-sakari.ailus@linux.intel.com> References: <20250410070623.3676647-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_000643_405455_3E1AB3EB X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add a local variable for a struct device pointer instead of obtaining the hwrng priv field and casting it as a struct device pointer whenever it's needed. Signed-off-by: Sakari Ailus --- drivers/char/hw_random/npcm-rng.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/npcm-rng.c b/drivers/char/hw_random/npcm-rng.c index 9ff00f096f38..beec96391af7 100644 --- a/drivers/char/hw_random/npcm-rng.c +++ b/drivers/char/hw_random/npcm-rng.c @@ -54,10 +54,11 @@ static void npcm_rng_cleanup(struct hwrng *rng) static int npcm_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait) { struct npcm_rng *priv = to_npcm_rng(rng); + struct device *dev = (struct device *)priv->rng.priv int retval = 0; int ready; - pm_runtime_get_sync((struct device *)priv->rng.priv); + pm_runtime_get_sync(dev); while (max) { if (wait) { @@ -79,8 +80,8 @@ static int npcm_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait) max--; } - pm_runtime_mark_last_busy((struct device *)priv->rng.priv); - pm_runtime_put_sync_autosuspend((struct device *)priv->rng.priv); + pm_runtime_mark_last_busy(dev); + pm_runtime_put_sync_autosuspend(dev); return retval || !wait ? retval : -EIO; } -- 2.39.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE36EC3601E for ; Thu, 10 Apr 2025 07:08:51 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZY9rT38tyz3g6k for ; Thu, 10 Apr 2025 17:08:09 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1744268874; cv=none; b=BGXCLG71WLq+MUk6rNwm5+RJF6pz+61bNqWESBVwniHflfFBH1Ylv+uZKpqW6gY+9FHDbvUCOf5momPF1ka88CUWIISHXdWA18SZrxwVH6FL1bngrFWstEn75DUlkee/BFFEXDWgN8lTzQ/wVvywkpTzSGXDs9lY9GmCyC95pzvZbaF0rXWKxUSrRh53S5V5QyOwgHHQ3t/oE3O7UOiyxsfAc4vjXpxRJSPhSJRWyN5ECS4ECPzys5o3CU2vEZLa9NFFXEfIXTCRWrqBjnEYBqQPak2j1ams6ZPKG6xyFUaLGdCkLmLaqnlVbjt4FmX77dHJQeIiVSPCJDUqAEXjKQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1744268874; c=relaxed/relaxed; bh=6DooyLKKYj3wKO7vJaSrsdZC2t9Wx01KgJ5YQqX5GS4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JTIOpXVQluPyMUac/mzywnQlxirAdkoNqNZFnnPfwiG2N8KfszzeEQ7BKuJsW1AFJSwUsjdYAt0S5WkDvgAqm35DQHX/jFweMx4J7okX1baGEOJWSpOjP9LNgoDtoEpevcy88/v7nRBeczSiNsXGz7vdW49uwI99+kK5aPKZMhulfOOacL59wddL9uSFoJ6Cb1TYRi2sxiT3347fOrmHB9NbNodjHnR53qSqbAx1w5uP6pr6uHYRdpDRkpXfI5HidG79bGe7HpBLx7TndIrp+y4zC8XKJWuIwy5xfzduwX3OF3ImBCRsLZRbyZbgkDYxbdQtSeMtqjN4QFUxbSH49w== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=YLMxFZul; dkim-atps=neutral; spf=none (client-ip=198.175.65.20; helo=mgamail.intel.com; envelope-from=sakari.ailus@linux.intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=YLMxFZul; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=198.175.65.20; helo=mgamail.intel.com; envelope-from=sakari.ailus@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZY9r73Bygz3bm3 for ; Thu, 10 Apr 2025 17:07:51 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744268872; x=1775804872; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eTuV2CyB5vjAJ0CZ1BcbW4eb89Fsn/ZCIyYBD5yo6Ow=; b=YLMxFZulE4v7EyfIi2Lh92KKQPdi82z1l9MASIJlyz5GFMkm79xFjhso hMZnHEC7zBSENmJI824k6ACMo/PjmtnJMKQYZv0S+u7U8Pao1owLo/b5o pf1hyS/LaV2HSH/BPYfIOGi9HffNDFLey5IG082RoRq3H5NkkRfuks9UD TNLTOgLCRNZtg1F3EmEuh5o2eW8w7XC+jk+Y1xncNTInuKlMJ0dDA7Zcj exSpiAHVPLP/xr2M5OAxpXpbGzD9kd8W1g+rsFaEdZPm/GTpnyhoeMuTH +kkiU1dvOlKNow4g11MBL0ZMQGxSBM/i3+LjllBF/X4EjtS/t6KPB8IsI A==; X-CSE-ConnectionGUID: 0P8iX+5DR7637zrAvu+kAw== X-CSE-MsgGUID: 2BSxPrD+Rrae0wgyaROMmA== X-IronPort-AV: E=McAfee;i="6700,10204,11399"; a="45484818" X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="45484818" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 00:06:40 -0700 X-CSE-ConnectionGUID: /9qgZoukRT2V3k+E473utg== X-CSE-MsgGUID: eCd3L+qyRjqOTOU2EOJUdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="128791505" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 00:06:36 -0700 Received: from punajuuri.localdomain (punajuuri.localdomain [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id B0BBE1203B9; Thu, 10 Apr 2025 10:06:33 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.96) (envelope-from ) id 1u2lzd-00FQTF-2I; Thu, 10 Apr 2025 10:06:33 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo From: Sakari Ailus To: linux-crypto@vger.kernel.org Subject: [PATCH 3/3] hwrng: npcm - Add a local variable for struct device pointer Date: Thu, 10 Apr 2025 10:06:23 +0300 Message-Id: <20250410070623.3676647-4-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250410070623.3676647-1-sakari.ailus@linux.intel.com> References: <20250410070623.3676647-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Avi Fishman , openbmc@lists.ozlabs.org, Sean Wang , Tomer Maimon , Nicolas Ferre , Tali Perry , Matthias Brugger , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Olivia Mackall , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Add a local variable for a struct device pointer instead of obtaining the hwrng priv field and casting it as a struct device pointer whenever it's needed. Signed-off-by: Sakari Ailus --- drivers/char/hw_random/npcm-rng.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/npcm-rng.c b/drivers/char/hw_random/npcm-rng.c index 9ff00f096f38..beec96391af7 100644 --- a/drivers/char/hw_random/npcm-rng.c +++ b/drivers/char/hw_random/npcm-rng.c @@ -54,10 +54,11 @@ static void npcm_rng_cleanup(struct hwrng *rng) static int npcm_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait) { struct npcm_rng *priv = to_npcm_rng(rng); + struct device *dev = (struct device *)priv->rng.priv int retval = 0; int ready; - pm_runtime_get_sync((struct device *)priv->rng.priv); + pm_runtime_get_sync(dev); while (max) { if (wait) { @@ -79,8 +80,8 @@ static int npcm_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait) max--; } - pm_runtime_mark_last_busy((struct device *)priv->rng.priv); - pm_runtime_put_sync_autosuspend((struct device *)priv->rng.priv); + pm_runtime_mark_last_busy(dev); + pm_runtime_put_sync_autosuspend(dev); return retval || !wait ? retval : -EIO; } -- 2.39.5