From: Florian Westphal <fw@strlen.de>
To: Huajian Yang <huajianyang@asrmicro.com>
Cc: pablo@netfilter.org, fw@strlen.de, kadlec@netfilter.org,
razor@blackwall.org, idosch@nvidia.com, davem@davemloft.net,
dsahern@kernel.org, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Move specific fragmented packet to slow_path instead of dropping it
Date: Thu, 10 Apr 2025 12:18:24 +0200 [thread overview]
Message-ID: <20250410101824.GA6272@breakpoint.cc> (raw)
In-Reply-To: <20250410075726.8599-1-huajianyang@asrmicro.com>
Huajian Yang <huajianyang@asrmicro.com> wrote:
> --- a/net/bridge/netfilter/nf_conntrack_bridge.c
> +++ b/net/bridge/netfilter/nf_conntrack_bridge.c
> @@ -61,18 +61,14 @@ static int nf_br_ip_fragment(struct net *net, struct sock *sk,
> struct sk_buff *frag;
>
> if (first_len - hlen > mtu ||
> - skb_headroom(skb) < ll_rs)
> - goto blackhole;
I would prefer to keep blackhole logic for the mtu tests,
i.e.
if (first_len - hlen > mtu)
goto blackhole;
same for the frag->len test in the skb_walk_frags loop.
From what I understood the problem is only because of
the lower devices' headroom requirement.
next prev parent reply other threads:[~2025-04-10 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 7:57 [PATCH] net: Move specific fragmented packet to slow_path instead of dropping it Huajian Yang
2025-04-10 10:18 ` Florian Westphal [this message]
2025-04-11 2:43 ` 答复: " Yang Huajian（杨华健）
-- strict thread matches above, loose matches on Subject: below --
2025-04-17 9:29 Huajian Yang
2025-04-17 14:12 ` Florian Westphal
2025-04-24 21:25 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410101824.GA6272@breakpoint.cc \
--to=fw@strlen.de \
--cc=bridge@lists.linux.dev \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=huajianyang@asrmicro.com \
--cc=idosch@nvidia.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.