From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@microsoft.com>
Cc: Konstantin Taranov <kotaranov@linux.microsoft.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Dexuan Cui <decui@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Long Li <longli@microsoft.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH rdma-next 3/3] RDMA/mana_ib: Add support of 4M, 1G, and 2G pages
Date: Thu, 10 Apr 2025 16:55:04 +0300 [thread overview]
Message-ID: <20250410135504.GU199604@unreal> (raw)
In-Reply-To: <PA1PR83MB0662BB595EEA7FE39B97422EB4B72@PA1PR83MB0662.EURPRD83.prod.outlook.com>
On Thu, Apr 10, 2025 at 01:38:39PM +0000, Konstantin Taranov wrote:
> >
> > > enum gdma_page_type {
> > > GDMA_PAGE_TYPE_4K,
> > > + GDMA_PAGE_SIZE_8K,
> > > + GDMA_PAGE_SIZE_16K,
> > > + GDMA_PAGE_SIZE_32K,
> > > + GDMA_PAGE_SIZE_64K,
> > > + GDMA_PAGE_SIZE_128K,
> > > + GDMA_PAGE_SIZE_256K,
> > > + GDMA_PAGE_SIZE_512K,
> > > + GDMA_PAGE_SIZE_1M,
> > > + GDMA_PAGE_SIZE_2M,
> > > + /* Only when
> > GDMA_DRV_CAP_FLAG_1_GDMA_PAGES_4MB_1GB_2GB is set */
> > > + GDMA_PAGE_SIZE_4M,
> > > + GDMA_PAGE_SIZE_1G = 18,
> > > + GDMA_PAGE_SIZE_2G
> >
> > Where are all these defines used?
>
> There are not used explicitly in this patch, but they can be used in theory.
Yes, please.
> I can remove unused defines in V2.
>
> >
> > Thanks
prev parent reply other threads:[~2025-04-10 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 14:45 [PATCH rdma-next 0/3] RDMA/mana_ib: extend MR support Konstantin Taranov
2025-04-04 14:45 ` [PATCH rdma-next 1/3] RDMA/mana_ib: Access remote atomic for MRs Konstantin Taranov
2025-04-09 12:28 ` Leon Romanovsky
2025-04-10 13:37 ` [EXTERNAL] " Konstantin Taranov
2025-04-10 13:54 ` Leon Romanovsky
2025-04-14 9:15 ` Konstantin Taranov
2025-04-04 14:45 ` [PATCH rdma-next 2/3] RDMA/mana_ib: support of the zero based MRs Konstantin Taranov
2025-04-04 14:45 ` [PATCH rdma-next 3/3] RDMA/mana_ib: Add support of 4M, 1G, and 2G pages Konstantin Taranov
2025-04-09 12:27 ` Leon Romanovsky
2025-04-10 13:38 ` [EXTERNAL] " Konstantin Taranov
2025-04-10 13:55 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410135504.GU199604@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.