From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>,
David Vernet <dvernet@meta.com>, Barret Rhoden <brho@google.com>,
Josh Don <joshdon@google.com>, Crystal Wood <crwood@redhat.com>,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
Juri Lelli <juri.lelli@redhat.com>,
lclaudio00@gmail.com, Ben Segall <bsegall@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] sched: do not call __put_task_struct() on rt if pi_blocked_on is set
Date: Thu, 10 Apr 2025 17:32:05 +0200 [thread overview]
Message-ID: <20250410153205.u92eJDos@linutronix.de> (raw)
In-Reply-To: <20250410075103.GV9833@noisy.programming.kicks-ass.net>
On 2025-04-10 09:51:03 [+0200], Peter Zijlstra wrote:
> > I complained about this special RT case in put_task_struct() when it was
> > first got introduced. Couldn't we just just unconditionally do the RCU
> > put?
>
> Yeah, please make it simpler, not more complex.
Just so we clear: simpler as in everyone does call_rcu() or RT does
always call_rcu() and everyone else __put_task_struct()? I mean we would
end up with one call chain I am just not sure how expensive it gets for
!RT.
Sebastian
next prev parent reply other threads:[~2025-04-10 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 18:58 [PATCH v2] sched: do not call __put_task_struct() on rt if pi_blocked_on is set Luis Claudio R. Goncalves
2025-04-10 6:48 ` Sebastian Andrzej Siewior
2025-04-10 7:51 ` Peter Zijlstra
2025-04-10 15:32 ` Sebastian Andrzej Siewior [this message]
2025-05-12 19:01 ` Luis Claudio R. Goncalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410153205.u92eJDos@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=brho@google.com \
--cc=bsegall@google.com \
--cc=clrkwllms@kernel.org \
--cc=crwood@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=dvernet@meta.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=lclaudio00@gmail.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.