All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Petr Tesařík" <petr@tesarici.cz>
Cc: Petr Tesarik <ptesarik@suse.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: core: warn if a GFP zone flag is passed to hcd_buffer_alloc()
Date: Thu, 10 Apr 2025 08:10:02 +0200	[thread overview]
Message-ID: <2025041035-catchable-stopping-e345@gregkh> (raw)
In-Reply-To: <20250409174036.7ee76248@meshulam.tesarici.cz>

On Wed, Apr 09, 2025 at 05:40:36PM +0200, Petr Tesařík wrote:
> On Tue, 25 Mar 2025 14:40:00 +0100
> Petr Tesarik <ptesarik@suse.com> wrote:
> 
> > Remove a misleading comment and issue a warning if a zone modifier is
> > specified when allocating a hcd buffer.
> > 
> > There is no valid use case for a GFP zone modifier in hcd_buffer_alloc():
> > - PIO mode can use any kernel-addressable memory
> > - dma_alloc_coherent() ignores memory zone bits
> > 
> > This function is called by usb_alloc_coherent() and indirectly by
> > usb_submit_urb(). Despite the comment, no in-tree users currently pass
> > GFP_DMA.
> > 
> > Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> 
> I know this was posted during the merge window, but that's now over.
> Any comment on this patch?

Please give me a chance to catch up, it's been non-stop conference
travel during the merge window, and through this week :(

thanks,

greg k-h

  reply	other threads:[~2025-04-10  6:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 15:47 [PATCH] usb: core: do not allocate buffers from a DMA zone unnecessarily Petr Tesarik
2025-03-25 13:40 ` [PATCH v2] usb: core: warn if a GFP zone flag is passed to hcd_buffer_alloc() Petr Tesarik
2025-03-25 13:54   ` Petr Tesarik
2025-04-09 15:40   ` Petr Tesařík
2025-04-10  6:10     ` Greg Kroah-Hartman [this message]
2025-04-11 13:57   ` Greg Kroah-Hartman
2025-04-14  7:02     ` Petr Tesarik
2025-04-14  7:12       ` Greg Kroah-Hartman
2025-04-14  7:57         ` Petr Tesarik
2025-04-15  7:53       ` Oliver Neukum
2025-04-16  7:48         ` Petr Tesarik
2025-04-16  8:45           ` Oliver Neukum
2025-04-16 10:47             ` Petr Tesarik
2025-04-16 13:08               ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025041035-catchable-stopping-e345@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=petr@tesarici.cz \
    --cc=ptesarik@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.