From: Greg KH <gregkh@linuxfoundation.org>
To: Ivan Hu <ivan.hu@canonical.com>
Cc: krzysztof.kozlowski@linaro.org, limiao@kylinos.cn,
wangyuli@uniontech.com, jinxiaobo@uniontech.com,
huanglei@kylinos.cn, mathias.nyman@linux.intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: quirks: Add quirk to prefer vendor-specific configuration
Date: Thu, 10 Apr 2025 08:58:40 +0200 [thread overview]
Message-ID: <2025041055-debtless-delirium-d5ca@gregkh> (raw)
In-Reply-To: <20250410024626.981215-1-ivan.hu@canonical.com>
On Thu, Apr 10, 2025 at 10:46:26AM +0800, Ivan Hu wrote:
> Some USB devices with multiple configurations expose a vendor-specific
> interface class that should be preferred by default. However, the generic
> usb_choose_configuration() logic selects the first configuration whose
> first interface uses a non-vendor-specific class, which can lead to
> incomplete or limited functionality.
>
> Introduce a new quirk, USB_QUIRK_CHOOSE_VENDOR_SPEC_CFG, which
> instructs the USB core to prefer a configuration that contains a
> vendor-specific interface class when multiple configurations are present.
>
> Apply this quirk to the ASIX AX88179 USB Ethernet adapter
> (0x0b95:0x1790), which requires selecting its vendor-specific
> configuration for full functionality, instead of falling back to
> cdc_ncm.
Shouldn't this be done in userspace instead? And how does other
operating systems handle this, the "first" configuration is usually the
default for them as well, do they have some built-in quirk to handle
this or do they rely on a vendor-provided driver?
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-10 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 2:46 [PATCH] usb: quirks: Add quirk to prefer vendor-specific configuration Ivan Hu
2025-04-10 6:58 ` Greg KH [this message]
2025-04-11 5:25 ` ivanhu
2025-04-11 5:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025041055-debtless-delirium-d5ca@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=huanglei@kylinos.cn \
--cc=ivan.hu@canonical.com \
--cc=jinxiaobo@uniontech.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=limiao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=wangyuli@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.