From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F11C7C36010 for ; Fri, 11 Apr 2025 17:18:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9D9626F773; Fri, 11 Apr 2025 17:18:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id HjEzlz-yMhhj; Fri, 11 Apr 2025 17:18:54 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0D6DA6FA0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1744391934; bh=kX9Ee1NVwUilB8STm8lSv1BafeXWvkACUePwnVD+esY=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vNciVG3DTIdukNLu6uKDXIPR+GamV7cU2S3Dr5le+FVoKVL7MYog8dTQQNvg3xEr0 rpQ9MAbbEVLll300gTij1sLgJHZwx6Mbp6fonD3VjsblBJm4p3zHXDIi6SzT8AG6C4 NAYfuTBidyArVbxnXyJSfsgxu3zNtbhxtAAE33mZ5u5H59cyWvzgsePeGN0/t7wqDe F5agv9G2A00tW5QVZa87spez2ZpUoHYetZOeORmEo0tcWzFNCgQLI78YxUdKjXPFOx EV7UgS+prlLbE2SuV/yUUbWTSmbyrHtfq3EpAmWSHklup9kZ8ik81tVVmsVeoX6Ewf EZVubkyMfBJHA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 0D6DA6FA0D; Fri, 11 Apr 2025 17:18:54 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id DB90E193 for ; Fri, 11 Apr 2025 17:18:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BD54C417FB for ; Fri, 11 Apr 2025 17:18:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id v1aNm212rdIR for ; Fri, 11 Apr 2025 17:18:52 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=leon@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 11B0F41778 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 11B0F41778 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp4.osuosl.org (Postfix) with ESMTPS id 11B0F41778 for ; Fri, 11 Apr 2025 17:18:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0CB98A4ACB8; Fri, 11 Apr 2025 17:13:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D951BC4CEE2; Fri, 11 Apr 2025 17:18:48 +0000 (UTC) Date: Fri, 11 Apr 2025 20:18:44 +0300 From: Leon Romanovsky To: Larysa Zaremba Cc: Alexander Lobakin , intel-wired-lan@lists.osuosl.org, Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Przemek Kitszel , Jiri Pirko , Tatyana Nikolova , Andrew Lunn , Michael Ellerman , Maciej Fijalkowski , Lee Trager , Madhavan Srinivasan , Sridhar Samudrala , Jacob Keller , Michal Swiatkowski , Mateusz Polchlopek , Ahmed Zaki , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Karlsson, Magnus" , Emil Tantilov , Madhu Chittim , Josh Hay , Milena Olech , pavan.kumar.linga@intel.com, "Singhai, Anjali" , Phani R Burra Message-ID: <20250411171844.GW199604@unreal> References: <20250408124816.11584-1-larysa.zaremba@intel.com> <20250408124816.11584-6-larysa.zaremba@intel.com> <20250410082137.GO199604@unreal> <20250410112349.GP199604@unreal> <20250410134443.GS199604@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744391930; bh=lRKwdQ9StQwDkVSRqJkrGUFaZtKmCreOQJCWpPe6TOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d/7sWOt23ZlZr8J+iLl1EYrM58L9dFPTvPbIlatsExxzGuIxVT1UUyyg24+oQVGry SEdQi1+e99GeDZlxUNKzSEdEbYr7RbmFyrko36wM3zekG37pcpdzPMYByqN2JZNyCy qh/hETc2eQGD335bHdFLqds2ebuIy4c+nlaftBeMyUjnicXyVS/0M6/8w+/3aYHYVW Z1wX9usjrS7T0bs4Pg2OKOJNMvTe9sfwKZkNh9QF7AGN2ebb/pheWaaz+JkwRVOz0C qdvfN9sznMUUTprszvLIW9J75jwipVwWkKsimhjA+KJJ6bKkN+5KCPLtuBc6x5FjhR IfbGLAPmEWB1g== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=d/7sWOt2 Subject: Re: [Intel-wired-lan] [PATCH iwl-next 05/14] libeth: add control queue support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Apr 10, 2025 at 03:59:23PM +0200, Larysa Zaremba wrote: > On Thu, Apr 10, 2025 at 04:44:43PM +0300, Leon Romanovsky wrote: > > On Thu, Apr 10, 2025 at 03:05:19PM +0200, Alexander Lobakin wrote: > > > From: Leon Romanovsky > > > Date: Thu, 10 Apr 2025 14:23:49 +0300 > > > > > > > On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote: > > > >> On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote: > > > >>> On Tue, Apr 08, 2025 at 02:47:51PM +0200, Larysa Zaremba wrote: > > > >>>> From: Phani R Burra > > > >>>> > > > >>>> Libeth will now support control queue setup and configuration APIs. > > > >>>> These are mainly used for mailbox communication between drivers and > > > >>>> control plane. > > > >>>> > > > >>>> Make use of the page pool support for managing controlq buffers. > > > > <...> > > > > > >> Module dependencies are as follows: > > > >> > > > >> libeth_rx and libeth_pci do not depend on other modules. > > > >> libeth_cp depends on both libeth_rx and libeth_pci. > > > >> idpf directly uses libeth_pci, libeth_rx and libeth_cp. > > > >> ixd directly uses libeth_cp and libeth_pci. > > > > > > > > You can do whatever module architecture for netdev devices, but if you > > > > plan to expose it to RDMA devices, I will vote against any deep layered > > > > module architecture for the drivers. > > > > > > No plans for RDMA there. > > > > > > Maybe link the whole kernel to one vmlinux then? > > > > It seems that you didn't understand at all about what we are talking > > here. Please use the opportunity that you are working for the same > > company with Larysa and ask her offline. She understood perfectly about > > which modules we are talking. > > > > While I do understand what kind of module relationship you consider problematic, Awesome, thanks. > I still struggle to understand why stateless lib hierarchy can be problematic. As I said already, I wrote my remark as a general comment. It is just a matter of time when perfectly working system will be changed to less working one. So when you and Alexander are focused to see what is wrong now, I see what can be in the future. To make it clear, even for people who sentimentally attached to libeth code: I didn't ask to change anything, just tried to understand why you did it like you did it. > The fixes that you linked relate more to problematic resource sharing, of which > libeth has none, it does not have its own memory or its own threads, this is > just collection of data structures and functions. It is just a matter of time and you will get same issues like I posted. Thanks > > > > > > > > > > > > BTW, please add some Intel prefix to the modules names, they shouldn't > > > > be called in generic names like libeth, e.t.c > > > > > > Two modules with the same name can't exist within the kernel. libeth was > > > available and I haven't seen anyone wanting to take it. It's not common > > > at all to name a module starting with "lib". > > > > Again, please talk with Larysa. ETH part is problematic in libeth name > > and not LIB. > > > > Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08BE221DB3; Fri, 11 Apr 2025 17:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744391930; cv=none; b=ZzJejCxggsebj8jaW5L8MBujjfKlgH+Lcu8WkrS1ymicd/4rIn0/xZTBw3uVRC4rFbDH3j4CnBkGnikMttnPYsrOfqL5yZnPpMrjwFlPv/tMGABn+icg1r1kAx1TgULnvbOVMTASYIxdU/N/4vsdzBR7R3z8A85iABlQvXFHcts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744391930; c=relaxed/simple; bh=lRKwdQ9StQwDkVSRqJkrGUFaZtKmCreOQJCWpPe6TOg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uz38ZscTfHLAQQD3BVrwci42KC0arNJESyV1U5Q9uiis6V7EMpna6Z+Xs9wQtC4n8gPvqrBaznlcISeeRTJPtg65v/2GJ1mNxCQ36YRO9kwJGXEGx/agn5R4YPfAdADInvjFRdldcgNKtsX+uNjifOUPNtjph/7hzCa6/clFcHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d/7sWOt2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d/7sWOt2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D951BC4CEE2; Fri, 11 Apr 2025 17:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744391930; bh=lRKwdQ9StQwDkVSRqJkrGUFaZtKmCreOQJCWpPe6TOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d/7sWOt23ZlZr8J+iLl1EYrM58L9dFPTvPbIlatsExxzGuIxVT1UUyyg24+oQVGry SEdQi1+e99GeDZlxUNKzSEdEbYr7RbmFyrko36wM3zekG37pcpdzPMYByqN2JZNyCy qh/hETc2eQGD335bHdFLqds2ebuIy4c+nlaftBeMyUjnicXyVS/0M6/8w+/3aYHYVW Z1wX9usjrS7T0bs4Pg2OKOJNMvTe9sfwKZkNh9QF7AGN2ebb/pheWaaz+JkwRVOz0C qdvfN9sznMUUTprszvLIW9J75jwipVwWkKsimhjA+KJJ6bKkN+5KCPLtuBc6x5FjhR IfbGLAPmEWB1g== Date: Fri, 11 Apr 2025 20:18:44 +0300 From: Leon Romanovsky To: Larysa Zaremba Cc: Alexander Lobakin , intel-wired-lan@lists.osuosl.org, Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Przemek Kitszel , Jiri Pirko , Tatyana Nikolova , Andrew Lunn , Michael Ellerman , Maciej Fijalkowski , Lee Trager , Madhavan Srinivasan , Sridhar Samudrala , Jacob Keller , Michal Swiatkowski , Mateusz Polchlopek , Ahmed Zaki , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Karlsson, Magnus" , Emil Tantilov , Madhu Chittim , Josh Hay , Milena Olech , pavan.kumar.linga@intel.com, "Singhai, Anjali" , Phani R Burra Subject: Re: [PATCH iwl-next 05/14] libeth: add control queue support Message-ID: <20250411171844.GW199604@unreal> References: <20250408124816.11584-1-larysa.zaremba@intel.com> <20250408124816.11584-6-larysa.zaremba@intel.com> <20250410082137.GO199604@unreal> <20250410112349.GP199604@unreal> <20250410134443.GS199604@unreal> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 10, 2025 at 03:59:23PM +0200, Larysa Zaremba wrote: > On Thu, Apr 10, 2025 at 04:44:43PM +0300, Leon Romanovsky wrote: > > On Thu, Apr 10, 2025 at 03:05:19PM +0200, Alexander Lobakin wrote: > > > From: Leon Romanovsky > > > Date: Thu, 10 Apr 2025 14:23:49 +0300 > > > > > > > On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote: > > > >> On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote: > > > >>> On Tue, Apr 08, 2025 at 02:47:51PM +0200, Larysa Zaremba wrote: > > > >>>> From: Phani R Burra > > > >>>> > > > >>>> Libeth will now support control queue setup and configuration APIs. > > > >>>> These are mainly used for mailbox communication between drivers and > > > >>>> control plane. > > > >>>> > > > >>>> Make use of the page pool support for managing controlq buffers. > > > > <...> > > > > > >> Module dependencies are as follows: > > > >> > > > >> libeth_rx and libeth_pci do not depend on other modules. > > > >> libeth_cp depends on both libeth_rx and libeth_pci. > > > >> idpf directly uses libeth_pci, libeth_rx and libeth_cp. > > > >> ixd directly uses libeth_cp and libeth_pci. > > > > > > > > You can do whatever module architecture for netdev devices, but if you > > > > plan to expose it to RDMA devices, I will vote against any deep layered > > > > module architecture for the drivers. > > > > > > No plans for RDMA there. > > > > > > Maybe link the whole kernel to one vmlinux then? > > > > It seems that you didn't understand at all about what we are talking > > here. Please use the opportunity that you are working for the same > > company with Larysa and ask her offline. She understood perfectly about > > which modules we are talking. > > > > While I do understand what kind of module relationship you consider problematic, Awesome, thanks. > I still struggle to understand why stateless lib hierarchy can be problematic. As I said already, I wrote my remark as a general comment. It is just a matter of time when perfectly working system will be changed to less working one. So when you and Alexander are focused to see what is wrong now, I see what can be in the future. To make it clear, even for people who sentimentally attached to libeth code: I didn't ask to change anything, just tried to understand why you did it like you did it. > The fixes that you linked relate more to problematic resource sharing, of which > libeth has none, it does not have its own memory or its own threads, this is > just collection of data structures and functions. It is just a matter of time and you will get same issues like I posted. Thanks > > > > > > > > > > > > BTW, please add some Intel prefix to the modules names, they shouldn't > > > > be called in generic names like libeth, e.t.c > > > > > > Two modules with the same name can't exist within the kernel. libeth was > > > available and I haven't seen anyone wanting to take it. It's not common > > > at all to name a module starting with "lib". > > > > Again, please talk with Larysa. ETH part is problematic in libeth name > > and not LIB. > > > > Thanks