From: Jason Gunthorpe <jgg@nvidia.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
kernel test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org, dave.jiang@intel.com,
linux-cxl@vger.kernel.org
Subject: Re: [PATCH v3] fwctl/cxl: Fix uuid_t usage in uapi
Date: Fri, 11 Apr 2025 20:48:06 -0300 [thread overview]
Message-ID: <20250411234806.GD252886@nvidia.com> (raw)
In-Reply-To: <174430961702.617339.13963021112051029933.stgit@dwillia2-xfh.jf.intel.com>
On Thu, Apr 10, 2025 at 11:27:40AM -0700, Dan Williams wrote:
> The uuid_t type is kernel internal, and Paul reports the following build
> error when it is used in a uapi header:
>
> usr/include/cxl/features.h:59:9: error: unknown type name ‘uuid_t’
>
> Create a uuid type (__uapi_uuid_t) compatible with the longstanding
> definition uuid/uuid.h for userspace builds, and use uuid_t directly for
> kernel builds.
>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Reported-by: "Paul E. McKenney" <paulmck@kernel.org>
> Closes: http://lore.kernel.org/f6489337-67c7-48c8-b48a-58603ec15328@paulmck-laptop
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504050434.Eb4vugh5-lkp@intel.com/
> Fixes: 9b8e73cdb141 ("cxl: Move cxl feature command structs to user header")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> Changes since v2:
> * Drop the tinkering with __align_of__ and just document the safety
> rules (Jason)
>
> include/uapi/cxl/features.h | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
Applied thanks
Jason
prev parent reply other threads:[~2025-04-11 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 18:04 [PATCH v2] fwctl/cxl: Fix uuid_t usage in uapi Dan Williams
2025-04-10 18:27 ` [PATCH v3] " Dan Williams
2025-04-10 20:03 ` Dave Jiang
2025-04-10 21:32 ` Paul E. McKenney
2025-04-11 23:48 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411234806.GD252886@nvidia.com \
--to=jgg@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.