All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Wang <anthonywang513@gmail.com>
To: git@vger.kernel.org
Cc: ps@pks.im, karthik.188@gmail.com, shejialuo@gmail.com,
	christian.couder@gmail.com, shyamthakkar001@gmail.com,
	sunshine@sunshineco.com, gitster@pobox.com,
	Anthony Wang <anthonywang03@icloud.com>
Subject: [GSoC] [PATCH v6 0/1] t9811: be more precise to check importing of tags
Date: Sat, 12 Apr 2025 08:19:56 +0200	[thread overview]
Message-ID: <20250412061957.81747-1-anthonywang03@icloud.com> (raw)
In-Reply-To: <20250405103718.25160-1-anthonywang03@icloud.com>

In order to expose more testing outputs, we remove the piping of `git tag` 
outputs in order to expose the exit codes. In addition, we change the 
usage of `grep` to `git show-ref --verify` to check for the existence of
expected tags in a cleaner manner, preventing false positives. We also
check to make sure TAG_F1_ONLY does not exist, as it is not expected to be 
created in this test.

--------------
changes in v6:
- removed unneccesary calls to `git tag`
- changed commit message to better describe rationale for changes
- added missing sign-off to patch #1

changes in v5:
- moved commit message to message body, and fixed subject line
- fixed whitespace issues in patch #1

changes in v4:
- changed `grep` to `git show-ref --verify` to check for the existence of 
  tags, and added a test_must_fail check for the unexpected tag.
- consolidated the three commits into one, as the changes were not 
  significant enough to warrant three separate commits.
- added a new commit message to clarify the changes made.

changes in v3:
- patch #1 and #2 were missing my sign-off, which has now been added.
- patch #2 referenced a line number, which was not informative. A new 
  discription has been added referencing the context of the code.

changes in v2:
- patch #2 and #3 have been added to reduce confusion caused by the 
  implications of `grep` followed by `grep -q`, and increase debug 
  output.

 t/t9811-git-p4-label-import.sh | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

-- 
2.39.5 (Apple Git-154)


  parent reply	other threads:[~2025-04-12  6:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-05 10:37 [GSoC] [PATCH 1/1] t9811: avoid using pipes Anthony Wang
2025-04-07  7:51 ` Patrick Steinhardt
2025-04-07 11:18   ` [GSoC] [PATCH v2 0/3] t9811: Improve test coverage and clarity Anthony Wang
2025-04-07 11:18     ` [GSoC] [PATCH v2 1/3] t9811: avoid using pipes to expose exit codes Anthony Wang
2025-04-07 16:17       ` Eric Sunshine
2025-04-07 17:19       ` Junio C Hamano
2025-04-07 21:28         ` Anthony Wang
2025-04-08  0:17           ` Junio C Hamano
2025-04-08  7:35             ` Anthony Wang
2025-04-07 11:18     ` [GSoC] [PATCH v2 2/3] t9811: Remove the -q quiet mode from some instances of grep Anthony Wang
2025-04-07 16:26       ` Eric Sunshine
2025-04-07 22:11         ` Junio C Hamano
2025-04-07 11:18     ` [GSoC] [PATCH v2 3/3] t9811: Change `grep` to `test_grep` for debug output Anthony Wang
2025-04-07 17:25 ` [GSoC] [PATCH v3 0/3] t9811: Improve test coverage and clarity Anthony Wang
2025-04-07 17:25   ` [GSoC] [PATCH v3 1/3] t9811: avoid using pipes to expose exit codes Anthony Wang
2025-04-07 17:25   ` [GSoC] [PATCH v3 2/3] t9811: Remove the -q quiet mode from some instances of grep Anthony Wang
2025-04-07 17:25   ` [GSoC] [PATCH v3 3/3] t9811: Change `grep` to `test_grep` for debug output Anthony Wang
2025-04-08  8:08 ` [GSoC] [PATCH v4 0/1] t9811: Improve test coverage and clarity Anthony Wang
2025-04-08  8:08   ` [GSoC] [PATCH v4 1/1] Remove the pipe following the `git tag`, ensuring the exit code is not hidden. Add explicit verification to check for expected and unexpected tags, increasing specificity and future-proofing a portion of the test Anthony Wang
2025-04-08  9:55     ` Karthik Nayak
2025-04-08 11:48 ` [GSoC] [PATCH v5 0/1] t9811: Improve test coverage and clarity Anthony Wang
2025-04-08 11:48   ` [GSoC] [PATCH v5 1/1] " Anthony Wang
2025-04-08 21:21     ` Junio C Hamano
2025-04-08 21:28       ` Eric Sunshine
2025-04-09  8:15         ` Anthony Wang
2025-04-09 13:29           ` Junio C Hamano
2025-04-12  6:19 ` Anthony Wang [this message]
2025-04-12  6:19   ` [GSoC] [PATCH v6 1/1] t9811: be more precise to check importing of tags Anthony Wang
2025-04-15 14:55     ` Junio C Hamano
2025-04-16 15:03       ` Anthony Wang
2025-04-16 14:59 ` [GSoC] [PATCH v7 0/1] " Anthony Wang
2025-04-16 14:59   ` [GSoC] [PATCH v7 1/1] " Anthony Wang
2025-04-18 18:12     ` Junio C Hamano
2025-04-18 21:03       ` Junio C Hamano
2025-04-18 21:41         ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250412061957.81747-1-anthonywang03@icloud.com \
    --to=anthonywang513@gmail.com \
    --cc=anthonywang03@icloud.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    --cc=shejialuo@gmail.com \
    --cc=shyamthakkar001@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.