Re: [PATCH 6.6.y] nvme-rdma: unquiesce admin_q before destroy it

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 5858b687559809f05393af745cbadf06dee61295

WARNING: Author mismatch between patch and upstream commit:
Backport author: Feng Liu<Feng.Liu3@windriver.com>
Commit author: Chunguang.xu<chunguang.xu@shopee.com>

Status in newer kernel trees:
6.14.y | Present (exact SHA1)
6.13.y | Present (exact SHA1)
6.12.y | Present (different SHA1: 05b436f3cf65)

Note: The patch differs from the upstream commit:
---
1:  5858b68755980 ! 1:  4d596a05770c2 nvme-rdma: unquiesce admin_q before destroy it
    @@ Metadata
      ## Commit message ##
         nvme-rdma: unquiesce admin_q before destroy it
     
    +    [ Upstream commit 5858b687559809f05393af745cbadf06dee61295 ]
    +
         Kernel will hang on destroy admin_q while we create ctrl failed, such
         as following calltrace:
     
    @@ Commit message
         Reviewed-by: Christoph Hellwig <hch@lst.de>
         Reviewed-by: Hannes Reinecke <hare@suse.de>
         Signed-off-by: Keith Busch <kbusch@kernel.org>
    +    [Minor context change fixed]
    +    Signed-off-by: Feng Liu <Feng.Liu3@windriver.com>
    +    Signed-off-by: He Zhe <Zhe.He@windriver.com>
     
      ## drivers/nvme/host/rdma.c ##
     @@ drivers/nvme/host/rdma.c: static int nvme_rdma_setup_ctrl(struct nvme_rdma_ctrl *ctrl, bool new)
    + 		nvme_rdma_free_io_queues(ctrl);
      	}
      destroy_admin:
    - 	nvme_stop_keep_alive(&ctrl->ctrl);
     -	nvme_quiesce_admin_queue(&ctrl->ctrl);
     -	blk_sync_queue(ctrl->ctrl.admin_q);
     -	nvme_rdma_stop_queue(&ctrl->queues[0]);
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.6.y        |  Success    |  Success   |