From: Jakub Kicinski <kuba@kernel.org>
To: hanhuihui <hanhuihui5@huawei.com>
Cc: <idosch@idosch.org>, <dsahern@kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] resume oif rule match l3mdev in fib_lookup
Date: Sat, 12 Apr 2025 16:25:28 -0700 [thread overview]
Message-ID: <20250412162528.24dc5105@kernel.org> (raw)
In-Reply-To: <20250412131910.15559-1-hanhuihui5@huawei.com>
On Sat, 12 Apr 2025 21:19:10 +0800 hanhuihui wrote:
> flowi_oif will be reset if flowi_oif set to a l3mdev (e.g., VRF) device.
> This causes the oif rule to fail to match the l3mdev device in fib_lookup.
> Let's get back to previous behavior.
>
> Fixes: 40867d74c374 ("net: Add l3mdev index to flow struct and avoid oif reset for port devices")
> Signed-off-by: hanhuihui hanhuihui5@huawei.com
If you'd like to go ahead with this approach you need to at the very
least adjust the fib_rule_tests.sh selftest..
next prev parent reply other threads:[~2025-04-12 23:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 1:58 VRF Routing Rule Matching Issue: oif Rules Not Working After Commit 40867d74c374 hanhuihui
2025-04-07 8:29 ` Ido Schimmel
2025-04-08 16:17 ` hanhuihui
2025-04-08 16:49 ` David Ahern
2025-04-08 19:54 ` Ido Schimmel
2025-04-12 13:17 ` hanhuihui
2025-04-12 13:19 ` [PATCH] resume oif rule match l3mdev in fib_lookup hanhuihui
2025-04-12 23:25 ` Jakub Kicinski [this message]
2025-04-14 7:17 ` Ido Schimmel
2025-04-14 17:24 ` Ido Schimmel
2025-04-15 14:11 ` hanhuihui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250412162528.24dc5105@kernel.org \
--to=kuba@kernel.org \
--cc=dsahern@kernel.org \
--cc=hanhuihui5@huawei.com \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.