From: Danilo Krummrich <dakr@kernel.org>
To: bhelgaas@google.com, kwilczynski@kernel.org,
gregkh@linuxfoundation.org, rafael@kernel.org,
abdiel.janulgue@gmail.com
Cc: ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu,
daniel.almeida@collabora.com, robin.murphy@arm.com,
linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH v2 0/9] Implement "Bound" device context
Date: Sun, 13 Apr 2025 19:36:55 +0200 [thread overview]
Message-ID: <20250413173758.12068-1-dakr@kernel.org> (raw)
Currently, we do not ensure that APIs that require a bound device instance can
only be called with a bound device.
Examples of such APIs are Devres, dma::CoherentAllocation and
pci::Device::iomap_region().
This patch series introduces the "Bound" device context such that we can ensure
to only ever pass a bound device to APIs that require this precondition.
In order to get there, we need some prerequisites:
(1) Implement macros to consistently derive Deref implementations for the
different device contexts. For instance, Device<Core> can be dereferenced to
Device<Bound>, since all device references we get from "core" bus callbacks
are guaranteed to be from a bound device. Device<Bound> can always be
dereferenced to Device (i.e. Device<Normal>), since the "Normal" device
context has no specific requirements.
(2) Implement device context support for the generic Device type. Some APIs such
as Devres and dma::CoherentAllocation work with generic devices.
(3) Preserve device context generics in bus specific device' AsRef
implementation, such that we can derive the device context when converting
from a bus specific device reference to a generic device reference.
With this, Devres::new(), for instance, can take a &Device<Bound> argument and
hence ensure that it can't be called with a Device reference that is not
guaranteed to be bound to a driver.
A branch containing the patches can be found in [1].
[1] https://web.git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust/device-bound
Changes in v2:
- add a safety requirement for impl_device_context_deref! (thanks to Benno for
working this out)
Danilo Krummrich (9):
rust: device: implement impl_device_context_deref!
rust: device: implement impl_device_context_into_aref!
rust: device: implement device context for Device
rust: platform: preserve device context in AsRef
rust: pci: preserve device context in AsRef
rust: device: implement Bound device context
rust: pci: move iomap_region() to impl Device<Bound>
rust: devres: require a bound device
rust: dma: require a bound device
rust/kernel/device.rs | 90 ++++++++++++++++++++++++++++++++++++++++-
rust/kernel/devres.rs | 17 ++++----
rust/kernel/dma.rs | 14 +++----
rust/kernel/pci.rs | 33 +++++----------
rust/kernel/platform.rs | 32 ++++-----------
5 files changed, 121 insertions(+), 65 deletions(-)
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
--
2.49.0
next reply other threads:[~2025-04-13 17:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-13 17:36 Danilo Krummrich [this message]
2025-04-13 17:36 ` [PATCH v2 1/9] rust: device: implement impl_device_context_deref! Danilo Krummrich
2025-04-13 19:38 ` Christian Schrefl
2025-04-14 10:41 ` Benno Lossin
2025-04-13 17:36 ` [PATCH v2 2/9] rust: device: implement impl_device_context_into_aref! Danilo Krummrich
2025-04-14 10:26 ` Benno Lossin
2025-04-13 17:36 ` [PATCH v2 3/9] rust: device: implement device context for Device Danilo Krummrich
2025-04-14 10:31 ` Benno Lossin
2025-04-15 20:47 ` Bjorn Helgaas
2025-04-13 17:36 ` [PATCH v2 4/9] rust: platform: preserve device context in AsRef Danilo Krummrich
2025-04-14 10:32 ` Benno Lossin
2025-04-13 17:37 ` [PATCH v2 5/9] rust: pci: " Danilo Krummrich
2025-04-14 10:33 ` Benno Lossin
2025-04-13 17:37 ` [PATCH v2 6/9] rust: device: implement Bound device context Danilo Krummrich
2025-04-14 10:44 ` Benno Lossin
2025-04-14 11:13 ` Danilo Krummrich
2025-04-14 12:15 ` Benno Lossin
2025-04-14 10:49 ` Benno Lossin
2025-04-14 10:56 ` Danilo Krummrich
2025-04-14 11:10 ` Benno Lossin
2025-04-15 20:44 ` Bjorn Helgaas
2025-04-13 17:37 ` [PATCH v2 7/9] rust: pci: move iomap_region() to impl Device<Bound> Danilo Krummrich
2025-04-14 10:44 ` Benno Lossin
2025-04-15 20:43 ` Bjorn Helgaas
2025-04-13 17:37 ` [PATCH v2 8/9] rust: devres: require a bound device Danilo Krummrich
2025-04-13 17:37 ` [PATCH v2 9/9] rust: dma: " Danilo Krummrich
2025-04-17 15:14 ` [PATCH v2 0/9] Implement "Bound" device context Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250413173758.12068-1-dakr@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.