From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 944F3C369B8 for ; Mon, 14 Apr 2025 13:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tYsmlOT5GxYgSLJwU+21J22ia9V2iVsXN94QgOs+tk4=; b=EpbMU9xoTNMl28GtTcstZEuuZM oXgrgcahvxd2m7UVAYNIFGdFSqZYKSckWIESWcxvT7wVD1LkvQ4c+AAmQKQU1PUZm36FRVHTCqZPS Yx6cBTK3ntITt/H5bgUjO/XRtKmbF4XLsL3ywzlp4tRRtE3E9BiZGkJrAfJpuF+4QF/D01otMNn4h ife3kPPNpgYhnzXx2USRchNDknnchhP2cd95CSuvNX4zr9WoChywcUeEyup05emiPJ6nU5eNv6sSb koHsRWGa3v6FHarG97lSQ2hqQd+A6ZPLefhfWgEKHVjQci3LLCX+hvBzZVNevTiurhhsTpHyv0aUH ToVAQj+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4JqF-000000027ib-3xnY; Mon, 14 Apr 2025 13:27:15 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4JqF-000000027hv-03LO for linux-nvme@lists.infradead.org; Mon, 14 Apr 2025 13:27:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C9216614B7; Mon, 14 Apr 2025 13:26:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C07A1C4CEE2; Mon, 14 Apr 2025 13:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744637234; bh=gmCfe1COb9qkb2Vi9dOY8JKW+Czq0eYOsx8yhYbnm9M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kgUfvESCuvkJi8aGlCDsbt71YRoDTOcSMJzMB9BlwsRu/7z0X6lKVynxVuLVGdROZ BWB19ZHd5Nst2F2FwbxOqoVTpXSIwG6JwgFD4wHzVo+uWuYCZAKxsmd5A2U9MGOgIk COVAhUn6pdQ8twEszcSJyQT6hFvvN1Hl87hkr2fzLuqKBNYzI2UxumBHH/2lM4qZfD l0Nc1BooNAt12OVXWwuPD2JJtJ37XqU1iekX/MZimSCE7qyp5S7x4+CfIkXzfbKESs 6kHv+KbPJ+FydmRMAmRSWaJmCP7uNxdJ0AnBGbFRYZku3jylK8WwVtq/GcUIJZVj9n PgadX2CqkZWVQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Daniel Wagner , Hannes Reinecke , Christoph Hellwig , Sasha Levin , james.smart@broadcom.com, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 6.14 27/34] nvmet-fc: put ref when assoc->del_work is already scheduled Date: Mon, 14 Apr 2025 09:26:03 -0400 Message-Id: <20250414132610.677644-27-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250414132610.677644-1-sashal@kernel.org> References: <20250414132610.677644-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.2 Content-Transfer-Encoding: 8bit X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Daniel Wagner [ Upstream commit 70289ae5cac4d3a39575405aaf63330486cea030 ] Do not leak the tgtport reference when the work is already scheduled. Signed-off-by: Daniel Wagner Reviewed-by: Hannes Reinecke Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/target/fc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c index a3a6dfe98d6fc..0dfffb3f39b06 100644 --- a/drivers/nvme/target/fc.c +++ b/drivers/nvme/target/fc.c @@ -1103,7 +1103,8 @@ static void nvmet_fc_schedule_delete_assoc(struct nvmet_fc_tgt_assoc *assoc) { nvmet_fc_tgtport_get(assoc->tgtport); - queue_work(nvmet_wq, &assoc->del_work); + if (!queue_work(nvmet_wq, &assoc->del_work)) + nvmet_fc_tgtport_put(assoc->tgtport); } static bool -- 2.39.5