From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Daniel Wagner <wagi@kernel.org>, Hannes Reinecke <hare@suse.de>,
Christoph Hellwig <hch@lst.de>, Sasha Levin <sashal@kernel.org>,
james.smart@broadcom.com, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org
Subject: [PATCH AUTOSEL 6.1 15/17] nvmet-fc: put ref when assoc->del_work is already scheduled
Date: Mon, 14 Apr 2025 09:30:46 -0400 [thread overview]
Message-ID: <20250414133048.680608-15-sashal@kernel.org> (raw)
In-Reply-To: <20250414133048.680608-1-sashal@kernel.org>
From: Daniel Wagner <wagi@kernel.org>
[ Upstream commit 70289ae5cac4d3a39575405aaf63330486cea030 ]
Do not leak the tgtport reference when the work is already scheduled.
Signed-off-by: Daniel Wagner <wagi@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/nvme/target/fc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 50953e0f9772d..ad43d36c537be 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -1105,7 +1105,8 @@ static void
nvmet_fc_schedule_delete_assoc(struct nvmet_fc_tgt_assoc *assoc)
{
nvmet_fc_tgtport_get(assoc->tgtport);
- queue_work(nvmet_wq, &assoc->del_work);
+ if (!queue_work(nvmet_wq, &assoc->del_work))
+ nvmet_fc_tgtport_put(assoc->tgtport);
}
static struct nvmet_fc_tgt_assoc *
--
2.39.5
next prev parent reply other threads:[~2025-04-14 13:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 13:30 [PATCH AUTOSEL 6.1 01/17] KVM: s390: Don't use %pK through tracepoints Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 02/17] udmabuf: fix a buf size overflow issue during udmabuf creation Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 03/17] selftests: ublk: fix test_stripe_04 Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 04/17] xen: Change xen-acpi-processor dom0 dependency Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 05/17] nvme: requeue namespace scan on missed AENs Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 06/17] ACPI: EC: Set ec_no_wakeup for Lenovo Go S Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 07/17] ACPI PPTT: Fix coding mistakes in a couple of sizeof() calls Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 08/17] nvme: re-read ANA log page after ns scan completes Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 09/17] objtool: Stop UNRET validation on UD2 Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 10/17] selftests/mincore: Allow read-ahead pages to reach the end of the file Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 11/17] x86/bugs: Use SBPB in write_ibpb() if applicable Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 12/17] x86/bugs: Don't fill RSB on VMEXIT with eIBRS+retpoline Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 13/17] x86/bugs: Don't fill RSB on context switch with eIBRS Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 14/17] nvmet-fc: take tgtport reference only once Sasha Levin
2025-04-14 13:30 ` Sasha Levin [this message]
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 16/17] net_sched: sch_sfq: use a temporary work area for validating configuration Sasha Levin
2025-04-14 13:30 ` [PATCH AUTOSEL 6.1 17/17] ext4: make block validity check resistent to sb bh corruption Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414133048.680608-15-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.