From: Jakub Kicinski <kuba@kernel.org>
To: "Xin Tian" <tianx@yunsilicon.com>
Cc: <netdev@vger.kernel.org>, <leon@kernel.org>,
<andrew+netdev@lunn.ch>, <pabeni@redhat.com>,
<edumazet@google.com>, <davem@davemloft.net>,
<jeff.johnson@oss.qualcomm.com>, <przemyslaw.kitszel@intel.com>,
<weihg@yunsilicon.com>, <wanry@yunsilicon.com>,
<jacky@yunsilicon.com>, <horms@kernel.org>,
<parthiban.veerasooran@microchip.com>, <masahiroy@kernel.org>,
<kalesh-anakkur.purayil@broadcom.com>, <geert+renesas@glider.be>,
<geert@linux-m68k.org>
Subject: Re: [PATCH net-next v10 10/14] xsc: Add eth needed qp and cq apis
Date: Mon, 14 Apr 2025 18:45:10 -0700 [thread overview]
Message-ID: <20250414184510.367bbcaf@kernel.org> (raw)
In-Reply-To: <20250411065316.2303550-11-tianx@yunsilicon.com>
On Fri, 11 Apr 2025 14:53:17 +0800 Xin Tian wrote:
> + netdev = ((struct xsc_adapter *)xdev->eth_priv)->netdev;
This double cast is a bit ugly, and it repeats 7 times in the initial
submission. Please add a helper somewhere, along the lines of:
static inline xsc_dev_to_netdev(struct xsc_core_device *xdev)
{
return ((struct xsc_adapter *)xdev->eth_priv)->netdev;
}
next prev parent reply other threads:[~2025-04-15 1:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 6:53 [PATCH net-next v10 00/14] xsc: ADD Yunsilicon XSC Ethernet Driver Xin Tian
2025-04-11 6:52 ` [PATCH net-next v10 01/14] xsc: Add xsc driver basic framework Xin Tian
2025-04-11 6:52 ` [PATCH net-next v10 02/14] xsc: Enable command queue Xin Tian
2025-04-11 6:52 ` [PATCH net-next v10 03/14] xsc: Add hardware setup APIs Xin Tian
2025-04-11 6:52 ` [PATCH net-next v10 04/14] xsc: Add qp and cq management Xin Tian
2025-04-11 6:52 ` [PATCH net-next v10 05/14] xsc: Add eq and alloc Xin Tian
2025-04-11 6:53 ` [PATCH net-next v10 06/14] xsc: Init pci irq Xin Tian
2025-04-11 6:53 ` [PATCH net-next v10 07/14] xsc: Init auxiliary device Xin Tian
2025-04-11 6:53 ` [PATCH net-next v10 08/14] xsc: Add ethernet interface Xin Tian
2025-04-11 6:53 ` [PATCH net-next v10 09/14] xsc: Init net device Xin Tian
2025-04-11 6:53 ` [PATCH net-next v10 10/14] xsc: Add eth needed qp and cq apis Xin Tian
2025-04-15 1:45 ` Jakub Kicinski [this message]
2025-04-11 6:53 ` [PATCH net-next v10 11/14] xsc: ndo_open and ndo_stop Xin Tian
2025-04-11 6:53 ` [PATCH net-next v10 12/14] xsc: Add ndo_start_xmit Xin Tian
2025-04-11 6:53 ` [PATCH net-next v10 13/14] xsc: Add eth reception data path Xin Tian
2025-04-15 1:43 ` Jakub Kicinski
2025-04-11 6:53 ` [PATCH net-next v10 14/14] xsc: add ndo_get_stats64 Xin Tian
-- strict thread matches above, loose matches on Subject: below --
2025-04-09 9:56 [PATCH net-next v10 00/14] xsc: ADD Yunsilicon XSC Ethernet Driver Xin Tian
2025-04-09 9:56 ` [PATCH net-next v10 10/14] xsc: Add eth needed qp and cq apis Xin Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414184510.367bbcaf@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms@kernel.org \
--cc=jacky@yunsilicon.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=tianx@yunsilicon.com \
--cc=wanry@yunsilicon.com \
--cc=weihg@yunsilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.