Re: [LTP] [PATCH v5 2/4] ci: add patchwork communication script

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

> Hi Petr,

> On 4/14/25 16:02, Petr Vorel wrote:
> > Generally LGTM, few notes below.
> > Feel free to ignore them, note at '-e' and '-z "$run" -o' (at the end) are bugs
> > worth to be fixed.
> We can remove -e, but what about -x ? It's verbose, but it's quite helping
> in the CI.
> Maybe I can just set -x before running the script in the workflow.

Sure, I'd definitely keep -x.

-e is up to you. You can keep it, but have to wrap commands with if:

if ! curl ...; then
	echo ... >&2
	exit 1
fi

Kind regards,
Petr

> The rest looks ok.

> - Andrea


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp