From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Eric Auger" <eric.auger@redhat.com>,
"Eric Auger" <eauger@redhat.com>,
"Jocelyn Falempe" <jfalempe@redhat.com>,
"David Airlie" <airlied@redhat.com>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Chia-I Wu" <olvaffe@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Simona Vetter" <simona@ffwll.ch>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev
Subject: Re: [PATCH v2] virtgpu: don't reset on shutdown
Date: Tue, 15 Apr 2025 10:00:48 -0400 [thread overview]
Message-ID: <20250415095922-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ge6675q3ahypfncrwbiodtcjnoftuza6ele5fhre3jmdeifsez@yy53fbwoulgo>
On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > +static void virtio_gpu_shutdown(struct virtio_device *vdev)
> > +{
> > + /*
> > + * drm does its own synchronization on shutdown.
> > + * Do nothing here, opt out of device reset.
> > + */
>
> I think a call to 'drm_dev_unplug()' is what you need here.
>
> take care,
> Gerd
My patch reverts the behaviour back to what it was, so pls go
ahead and send a patch on top? I won't be able to explain
what it does and why it's needed.
--
MST
next prev parent reply other threads:[~2025-04-15 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 13:59 [PATCH v2] virtgpu: don't reset on shutdown Michael S. Tsirkin
2025-04-15 11:16 ` Gerd Hoffmann
2025-04-15 14:00 ` Michael S. Tsirkin [this message]
2025-04-16 13:57 ` Gerd Hoffmann
2025-04-17 7:07 ` Thomas Zimmermann
2025-04-22 6:21 ` Gerd Hoffmann
2025-04-22 16:49 ` Eric Auger
2025-04-23 6:45 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415095922-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eauger@redhat.com \
--cc=eperezma@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gurchetansingh@chromium.org \
--cc=jasowang@redhat.com \
--cc=jfalempe@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=olvaffe@gmail.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.