All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Serbinenko <phcoder@gmail.com>
To: grub-devel@gnu.org
Cc: Vladimir Serbinenko <phcoder@gmail.com>
Subject: [PATCH v11 11/14] gcry: Ignore sign-compare warnings
Date: Tue, 15 Apr 2025 10:35:45 +0000	[thread overview]
Message-ID: <20250415103710.116109-12-phcoder@gmail.com> (raw)
In-Reply-To: <20250415103710.116109-1-phcoder@gmail.com>

libgcrypt itself is compiled with -Wno-sign-compare.
Do the same for consistency

Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
---
 conf/Makefile.common        |  2 +-
 grub-core/Makefile.core.def | 10 +++++-----
 util/import_gcry.py         |  2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/conf/Makefile.common b/conf/Makefile.common
index 0df4d6e7a..4d38ff034 100644
--- a/conf/Makefile.common
+++ b/conf/Makefile.common
@@ -81,7 +81,7 @@ CPPFLAGS_GNULIB = -I$(top_builddir)/grub-core/lib/gnulib -I$(top_srcdir)/grub-co
 CFLAGS_POSIX = -fno-builtin
 CPPFLAGS_POSIX = -I$(top_srcdir)/grub-core/lib/posix_wrap
 
-CFLAGS_GCRY = -Wno-error=sign-compare -Wno-missing-field-initializers -Wno-redundant-decls -Wno-undef $(CFLAGS_POSIX)
+CFLAGS_GCRY = -Wno-sign-compare -Wno-missing-field-initializers -Wno-redundant-decls -Wno-undef $(CFLAGS_POSIX)
 CPPFLAGS_GCRY = -I$(top_srcdir)/grub-core/lib/libgcrypt_wrap $(CPPFLAGS_POSIX) -D_GCRYPT_IN_LIBGCRYPT=1 -D_GCRYPT_CONFIG_H_INCLUDED=1 -I$(top_srcdir)/include/grub/gcrypt
 
 CPPFLAGS_EFIEMU = -I$(top_srcdir)/grub-core/efiemu/runtime
diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
index 770f6e0c5..56e407376 100644
--- a/grub-core/Makefile.core.def
+++ b/grub-core/Makefile.core.def
@@ -975,7 +975,7 @@ module = {
 module = {
   name = pgp;
   common = commands/pgp.c;
-  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls -Wno-sign-compare';
+  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls';
   cppflags = '$(CPPFLAGS_GCRY)';
 };
 
@@ -2184,7 +2184,7 @@ module = {
   name = dsa_sexp_test;
   common = tests/dsa_sexp_test.c;
 
-  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls -Wno-sign-compare';
+  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls';
   cppflags = '$(CPPFLAGS_GCRY)';
 };
 
@@ -2192,7 +2192,7 @@ module = {
   name = rsa_sexp_test;
   common = tests/rsa_sexp_test.c;
 
-  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls -Wno-sign-compare';
+  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls';
   cppflags = '$(CPPFLAGS_GCRY)';
 };
 
@@ -2556,7 +2556,7 @@ module = {
   common = lib/libgcrypt_wrap/mem.c;
   common = lib/libgcrypt-grub/cipher/md.c;
 
-  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls -Wno-sign-compare -Wno-unused-but-set-variable';
+  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls -Wno-unused-but-set-variable';
   cppflags = '$(CPPFLAGS_GCRY)';
 };
 
@@ -2568,7 +2568,7 @@ module = {
   common = lib/libgcrypt-grub/src/sexp.c;
   common = lib/b64dec.c;
 
-  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls -Wno-sign-compare';
+  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls';
   cppflags = '$(CPPFLAGS_GCRY)';
 };
 
diff --git a/util/import_gcry.py b/util/import_gcry.py
index 1be18cf91..a4411ecb9 100644
--- a/util/import_gcry.py
+++ b/util/import_gcry.py
@@ -551,7 +551,7 @@ for cipher_file in cipher_files:
                     confutil.write ("  common = grub-core/lib/libgcrypt-grub/cipher/%s;\n" % src)
             if modname == "gcry_ecc":
                 conf.write ("  common = lib/libgcrypt-grub/mpi/ec.c;\n")
-                conf.write ("  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls -Wno-sign-compare';\n")
+                conf.write ("  cflags = '$(CFLAGS_GCRY) -Wno-redundant-decls';\n")
             elif modname == "gcry_rijndael" or modname == "gcry_md4" or modname == "gcry_md5" or modname == "gcry_rmd160" or modname == "gcry_sha1" or modname == "gcry_sha256" or modname == "gcry_sha512" or modname == "gcry_tiger":
                 # Alignment checked by hand
                 conf.write ("  cflags = '$(CFLAGS_GCRY) -Wno-cast-align';\n");
-- 
2.49.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

  parent reply	other threads:[~2025-04-15 10:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 10:35 [PATCH v11 00/14] Upgrade libgcrypt to 1.11 Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 01/14] Import libgcrypt 1.11 Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 02/14] Import b64dec from gpg-error Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 03/14] b64dec: Adjust for compilation in GRUB environment Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 04/14] Adjust import script, definitions and API users for libgcrypt 1.11 Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 05/14] Add DSA and RSA SEXP tests Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 06/14] keccak: Disable acceleration with SSE asm Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 07/14] libgcrypt: Fix coverity warnings Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 08/14] Remove now unneeded gcrypt compilation flag Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 09/14] Implement __aeabi_uldivmod Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 10/14] Enable (u)divdi3 and (u)moddi3 for mips Vladimir Serbinenko
2025-04-15 10:35 ` Vladimir Serbinenko [this message]
2025-04-15 10:35 ` [PATCH v11 12/14] libgcrypt: Import blake family of hashes Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 13/14] import_gcry: Make compatible with python 3.4 Vladimir Serbinenko
2025-04-15 10:35 ` [PATCH v11 14/14] import_gcry: Fix pylint warnings Vladimir Serbinenko
  -- strict thread matches above, loose matches on Subject: below --
2025-04-10 22:00 [PATCH v11 00/14] Update libgcrypt to 1.11 Vladimir Serbinenko
2025-04-10 22:00 ` [PATCH v11 11/14] gcry: Ignore sign-compare warnings Vladimir Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250415103710.116109-12-phcoder@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.