From: Stefan Hajnoczi <stefanha@redhat.com>
To: Antoine Damhet <adamhet@scaleway.com>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH v2] Revert "virtio-net: Copy received header to buffer"
Date: Tue, 15 Apr 2025 11:33:33 -0400 [thread overview]
Message-ID: <20250415153333.GA283305@fedora> (raw)
In-Reply-To: <20250408145345.142947-1-adamhet@scaleway.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Tue, Apr 08, 2025 at 04:53:33PM +0200, Antoine Damhet wrote:
> This reverts commit 7987d2be5a8bc3a502f89ba8cf3ac3e09f64d1ce.
>
> The goal was to remove the need to patch the (const) input buffer
> with a recomputed UDP checksum by copying headers to a RW region and
> inject the checksum there. The patch computed the checksum only from the
> header fields (missing the rest of the payload) producing an invalid one
> and making guests fail to acquire a DHCP lease.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2727
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Antoine Damhet <adamhet@scaleway.com>
> ---
> v2: Rebased on master due to conflict with c17ad4b11bd2 (
> "virtio-net: Fix num_buffers for version 1")
Applied for QEMU 10.0, thanks!
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-04-15 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 14:53 [PATCH v2] Revert "virtio-net: Copy received header to buffer" Antoine Damhet
2025-04-10 19:00 ` Stefan Hajnoczi
2025-04-14 19:33 ` Stefan Hajnoczi
2025-04-14 22:48 ` Michael S. Tsirkin
2025-04-14 23:16 ` Stefan Hajnoczi
2025-04-15 15:33 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415153333.GA283305@fedora \
--to=stefanha@redhat.com \
--cc=adamhet@scaleway.com \
--cc=akihiko.odaki@daynix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.