From: Lee Jones <lee@kernel.org>
To: Mario Limonciello <superm1@kernel.org>
Cc: mario.limonciello@amd.com, danielt@kernel.org,
jingoohan1@gmail.com, Lennart Poettering <lennart@poettering.net>,
richard.purdie@linuxfoundation.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] docs: backlight: Clarify `actual_brightness`
Date: Tue, 15 Apr 2025 16:53:19 +0100 [thread overview]
Message-ID: <20250415155319.GZ372032@google.com> (raw)
In-Reply-To: <20250408192729.4091391-1-superm1@kernel.org>
On Tue, 08 Apr 2025, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> Currently userspace software systemd treats `brightness` and
> `actual_brightness` identically due to a bug found in an out of tree
> driver.
>
> This however causes problems for in-tree drivers that use brightness
> to report user requested `brightness` and `actual_brightness` to report
> what the hardware actually has programmed.
>
> Clarify the documentation to match the behavior described in commit
> 6ca017658b1f9 ("[PATCH] backlight: Backlight Class Improvements").
>
> Cc: Lennart Poettering <lennart@poettering.net>
> Cc: richard.purdie@linuxfoundation.org
> Link: https://github.com/systemd/systemd/pull/36881
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> Documentation/ABI/stable/sysfs-class-backlight | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/stable/sysfs-class-backlight b/Documentation/ABI/stable/sysfs-class-backlight
> index 6102d6bebdf9a..909cacde85041 100644
> --- a/Documentation/ABI/stable/sysfs-class-backlight
> +++ b/Documentation/ABI/stable/sysfs-class-backlight
> @@ -26,7 +26,9 @@ Date: March 2006
> KernelVersion: 2.6.17
> Contact: Richard Purdie <rpurdie@rpsys.net>
> Description:
> - Show the actual brightness by querying the hardware.
> + Show the actual brightness by querying the hardware. This
> + takes into account other factors besides the value programmed
> + for 'brightness' and may not match the value in 'brightness'.
Which factors? Under what circumstances may the values not match?
> Users: HAL
>
> What: /sys/class/backlight/<backlight>/max_brightness
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-04-15 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 19:27 [PATCH] docs: backlight: Clarify `actual_brightness` Mario Limonciello
2025-04-15 15:53 ` Lee Jones [this message]
2025-04-15 16:02 ` Mario Limonciello
2025-04-15 16:31 ` Lee Jones
2025-04-16 8:39 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415155319.GZ372032@google.com \
--to=lee@kernel.org \
--cc=danielt@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lennart@poettering.net \
--cc=mario.limonciello@amd.com \
--cc=richard.purdie@linuxfoundation.org \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.