Re: [RFC PATCH 1/4] ethdev: add support to provide link type

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 15 Apr 2025 12:38:18 +0530
Nithin Dabilpuram <nithind1988@gmail.com> wrote:

> On Fri, Apr 4, 2025 at 6:16 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Thu, 3 Apr 2025 12:38:34 +0530
> > Nithin Dabilpuram <ndabilpuram@marvell.com> wrote:
> >  
> > >  /**
> > >   * A structure used to retrieve link-level information of an Ethernet port.
> > >   */
> > > @@ -341,6 +354,7 @@ struct rte_eth_link {
> > >                       uint16_t link_duplex  : 1;  /**< RTE_ETH_LINK_[HALF/FULL]_DUPLEX */
> > >                       uint16_t link_autoneg : 1;  /**< RTE_ETH_LINK_[AUTONEG/FIXED] */
> > >                       uint16_t link_status  : 1;  /**< RTE_ETH_LINK_[DOWN/UP] */
> > > +                     uint16_t link_type    : 5;  /**< RTE_ETH_LINK_TYPE_* */
> > >               };
> > >       };
> > >  };  
> >
> > Seems like an ABI break, and not sure that all drivers will fill those bits with zero now.  
> 
> Generally ABI is between APP and all DPDK libraries/PMD and not
> between DPDK libraries and PMD ?

The problem is rte_eth_link is returne by rte_eth_link_get which is exposed
to the application.