From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AB93C369AB for ; Wed, 16 Apr 2025 00:59:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4C5D980EF7; Wed, 16 Apr 2025 00:59:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id i9aHDq-IEINr; Wed, 16 Apr 2025 00:59:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6D2BE813FF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1744765193; bh=g/67YHTEWGBhb8hK2XA67rXZbWA1CeLBweZw5/jNpLA=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=P6Wf4OcxyrhRFGj8qwrZXS+Jt4eXoZLBKkA9VVgv+iqFnXdIdWm/ZfIZEO/kgQfxH +xkfV9QBUXaDATmyNuLZWKtHMvxhhkfdQ0j4NV35T4BK3v3Y6Yn7AkBKZLaWhSrFlE q70ienl9TvJXn7Ikbe0ehNoG80X9/cgFScscGLOM/dh6tNK9BRHmMDleuOFN168ryd fu21y4gSGQHWKAVHiiTD3nT+kpq6RzRrXZIUp/Gt6AtqV3vXKBeovsH+aptC0T4eaR Hw4J+//9wCa/15MCEwldlPJbwP4pLhxiwO68IjTOCz9lSL51YjxYLkFLZHP320HGGE HlHl7gbPY7JrQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 6D2BE813FF; Wed, 16 Apr 2025 00:59:53 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 45F3FDE for ; Wed, 16 Apr 2025 00:59:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 36FDB610F9 for ; Wed, 16 Apr 2025 00:59:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id cs3Kpw5TiNew for ; Wed, 16 Apr 2025 00:59:51 +0000 (UTC) X-Greylist: delayed 350 seconds by postgrey-1.37 at util1.osuosl.org; Wed, 16 Apr 2025 00:59:51 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org AB3BF61028 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AB3BF61028 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp3.osuosl.org (Postfix) with ESMTPS id AB3BF61028 for ; Wed, 16 Apr 2025 00:59:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0F78945157; Wed, 16 Apr 2025 00:54:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B1BAC4CEE7; Wed, 16 Apr 2025 00:54:00 +0000 (UTC) Date: Tue, 15 Apr 2025 17:53:59 -0700 From: Jakub Kicinski To: Przemek Kitszel Cc: Jaroslav Pulchart , , , , Tony Nguyen , "Igor Raits" , Daniel Secik , "Zdenek Pesek" , "Eric Dumazet" , Martin Karsten , "Ahmed Zaki" , "Czapnik, Lukasz" , Michal Swiatkowski Message-ID: <20250415175359.3c6117c9@kernel.org> In-Reply-To: <4a061a51-8a6c-42b8-9957-66073b4bc65f@intel.com> References: <4a061a51-8a6c-42b8-9957-66073b4bc65f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744764841; bh=zTO0PGprkgHrXrHtmLAb9UQPjHOxwm5tC+XNO/WFDMM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gpYpTJ/XcB6rNrlzdN38czMx28ncPMQWzIk4XV0cH7UgdExtg3aRPzYT/S8Y2y0OH xQm3dnFps5nHcA6JK15Vp1xw2yTsebsBUkxslUPoG3DsYdqMsf8gz3WKMZCEMMtTBj NTtrdi9tYicLe4ALM03thVyzN2SW4iEVCq4nFasbLcEx3zgqhwYAQOB4FDItwuYLaR CE//60QH70NzCGgXI7NHPZKumXZ8W23OyEQpd4IxnVzG3oyTXu/+btdI8ya4Qltu0+ 0dMTvc8vMkKV/+76f9GybP0MX6TI2LAbbry5SQQ3mY0x1cYNOLHRiwyhr7fdXbl5XY Om/IrgVbCbtUg== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=gpYpTJ/X Subject: Re: [Intel-wired-lan] Increased memory usage on NUMA nodes with ICE driver after upgrade to 6.13.y (regression in commit 492a044508ad) X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 15 Apr 2025 16:38:40 +0200 Przemek Kitszel wrote: > > We traced the issue to commit 492a044508ad13a490a24c66f311339bf891cb5f > > "ice: Add support for persistent NAPI config". > > thank you for the report and bisection, > this commit is ice's opt-in into using persistent napi_config > > I have checked the code, and there is nothing obvious to inflate memory > consumption in the driver/core in the touched parts. I have not yet > looked into how much memory is eaten by the hash array of now-kept > configs. +1 also unclear to me how that commit makes any difference. Jaroslav, when you say "traced" what do you mean? CONFIG_MEM_ALLOC_PROFILING ? The napi_config struct is just 24B. The queue struct (we allocate napi_config for each queue) is 320B... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 769651CEAC2 for ; Wed, 16 Apr 2025 00:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744764841; cv=none; b=Gaeds/jnExd9FsDo8UPikH+1bhyZos2WdgQbGw775cUFJjQgWhQ6jrBsAp5plb9OKodrTAIGWleW/ItyLV7vC6yrjH+vxMRr5HRtKI6bjyWq0HTAqM+JMmjQzx+SfolbQQ6TFMgKdS6T0xVFEvrsGIGqufTX9F8QCVasWUAlJRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744764841; c=relaxed/simple; bh=zTO0PGprkgHrXrHtmLAb9UQPjHOxwm5tC+XNO/WFDMM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LCEkGq93aLzS5yZstPh22+fsxKpbtL2gFjVv90q0o3pnGWia9BYB+FqqpRD3cmG2Dm0TpRyODy84JeHIkNyC6bJJGVtJfxocSBoE9sdG2nO/UbPXOdTaRf6tEzD7iaxPWIigghB31Hh/cnfSHFe74/10ShaqRMNupsvmhyu0aUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gpYpTJ/X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gpYpTJ/X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B1BAC4CEE7; Wed, 16 Apr 2025 00:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744764841; bh=zTO0PGprkgHrXrHtmLAb9UQPjHOxwm5tC+XNO/WFDMM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gpYpTJ/XcB6rNrlzdN38czMx28ncPMQWzIk4XV0cH7UgdExtg3aRPzYT/S8Y2y0OH xQm3dnFps5nHcA6JK15Vp1xw2yTsebsBUkxslUPoG3DsYdqMsf8gz3WKMZCEMMtTBj NTtrdi9tYicLe4ALM03thVyzN2SW4iEVCq4nFasbLcEx3zgqhwYAQOB4FDItwuYLaR CE//60QH70NzCGgXI7NHPZKumXZ8W23OyEQpd4IxnVzG3oyTXu/+btdI8ya4Qltu0+ 0dMTvc8vMkKV/+76f9GybP0MX6TI2LAbbry5SQQ3mY0x1cYNOLHRiwyhr7fdXbl5XY Om/IrgVbCbtUg== Date: Tue, 15 Apr 2025 17:53:59 -0700 From: Jakub Kicinski To: Przemek Kitszel Cc: Jaroslav Pulchart , , , , Tony Nguyen , "Igor Raits" , Daniel Secik , "Zdenek Pesek" , "Eric Dumazet" , Martin Karsten , "Ahmed Zaki" , "Czapnik, Lukasz" , Michal Swiatkowski Subject: Re: Increased memory usage on NUMA nodes with ICE driver after upgrade to 6.13.y (regression in commit 492a044508ad) Message-ID: <20250415175359.3c6117c9@kernel.org> In-Reply-To: <4a061a51-8a6c-42b8-9957-66073b4bc65f@intel.com> References: <4a061a51-8a6c-42b8-9957-66073b4bc65f@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 15 Apr 2025 16:38:40 +0200 Przemek Kitszel wrote: > > We traced the issue to commit 492a044508ad13a490a24c66f311339bf891cb5f > > "ice: Add support for persistent NAPI config". > > thank you for the report and bisection, > this commit is ice's opt-in into using persistent napi_config > > I have checked the code, and there is nothing obvious to inflate memory > consumption in the driver/core in the touched parts. I have not yet > looked into how much memory is eaten by the hash array of now-kept > configs. +1 also unclear to me how that commit makes any difference. Jaroslav, when you say "traced" what do you mean? CONFIG_MEM_ALLOC_PROFILING ? The napi_config struct is just 24B. The queue struct (we allocate napi_config for each queue) is 320B...