All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Christian Schrefl" <chrisi.schrefl@gmail.com>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	"Russ Weight" <russ.weight@linux.dev>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc`
Date: Tue, 15 Apr 2025 16:57:45 +0200	[thread overview]
Message-ID: <2025041537-refusal-suspense-3e7b@gregkh> (raw)
In-Reply-To: <CANiq72kJ+tv-P6+Yq7Bg+J73q93m+EKV_4E-GR=sdY5KRgCs6w@mail.gmail.com>

On Sun, Apr 13, 2025 at 10:21:01PM +0200, Miguel Ojeda wrote:
> On Sun, Apr 13, 2025 at 9:27 PM Christian Schrefl
> <chrisi.schrefl@gmail.com> wrote:
> >
> > The `FwFunc` struct contains an function with a char pointer argument,
> > for which a `*const u8` pointer was used. This is not really the
> > "proper" type for this, so use a `*const kernel::ffi::c_char` pointer
> > instead.
> 
> If I don't take it:
> 
> Acked-by: Miguel Ojeda <ojeda@kernel.org>

Thanks, I'll take it now.

greg k-h

  reply	other threads:[~2025-04-15 14:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-13 19:26 [PATCH v3] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc` Christian Schrefl
2025-04-13 20:21 ` Miguel Ojeda
2025-04-15 14:57   ` Greg Kroah-Hartman [this message]
2025-04-15 14:59     ` Greg Kroah-Hartman
2025-04-14 12:41 ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025041537-refusal-suspense-3e7b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=chrisi.schrefl@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=russ.weight@linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.