Re: [PATCH v4 4/4] net/macb: add necessary docs and update related files

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed,  2 Apr 2025 06:59:31 +0000
liwencheng <liwencheng@phytium.com.cn> wrote:

> +Features of the MACB PMD are:
> +
> +* Speed capabilities
> +* Link status
> +* Tx Queue start/stop
> +* Multiple queues for TX and RX
> +* CRC offload
> +* Jumbo frames supported

I see no operations functions for Tx queue/start stop
in macb_ops. Obviously not tested.

int
rte_eth_dev_tx_queue_start(uint16_t port_id, uint16_t tx_queue_id)
{
	struct rte_eth_dev *dev;
	int ret;

	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
	dev = &rte_eth_devices[port_id];

	if (!dev->data->dev_started) {
		RTE_ETHDEV_LOG_LINE(ERR,
			"Port %u must be started before start any queue",
			port_id);
		return -EINVAL;
	}

	ret = eth_dev_validate_tx_queue(dev, tx_queue_id);
	if (ret != 0)
		return ret;

	if (dev->dev_ops->tx_queue_start == NULL)
		return -ENOTSUP;