From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D5D7C369BD for ; Wed, 16 Apr 2025 15:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=kxRWREi2/yn3kvLr3/tieNo8VjE5QaX3gIFqLkknoFw=; b=VaXwuvK7UD5e+yA/RA6aVBA/6F /MthBLRqOoBBLpUtdFWAQsXk4GM+48zpJbsoV2X+B0ep33M0AWKXfcPqbznzcxlUf4+6KDcj/3fBG v4zAN13ym322iqVM9/ItukkST1MvAkfmcVWvqODz7iKjYhQxWf+HDp301qWqMwXw+VFDWuH48k71E +RmzDojdFLSt3V2XW/LOjEfMuA5WyOmHjhGAL3WKLOmWHx/jdc5zBvcdPks+/KsR5dBpsUpVppIPp Dmnuefm4cew5Fq7pHMbyT9stLRXPP5p5nozcec8Cc9oNucGA6OEdRfftd3UGrGGDBZQi8wnfTmVy2 Wxw6nHFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u54zc-0000000A8GY-1QJO; Wed, 16 Apr 2025 15:48:04 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u53kL-00000009tPE-0fnB; Wed, 16 Apr 2025 14:28:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 55EAC44BF1; Wed, 16 Apr 2025 14:28:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3340C4AF0D; Wed, 16 Apr 2025 14:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744813692; bh=YohtpSKfziHQfMPNcNaGHRCZ3p7uL5Xf3nCpnAqt2us=; h=From:To:Cc:Subject:Date:From; b=f1gwotxw8qmedNGFyJRw+hTIvIeLRizf3DPhc4hSAPcwnjmnwKmg5oalAo00kvQqv +dpTyPmDKid5E7Mrz7nHDpP+08ZKx3VqELDemHzFHSvYKBt6Ya0zlT+FaiB8kDNNCI JzExyn0z1sT06R9r/aTQps4wyyzGn4FH2zRVMUL2SIFSCnoBsYCqZx7jF/I2MdYgkB x2O0oS+5yGdH16Tj1tMfiuLWxr0pPljQuuXmYNRqK2w+d8517VqI/H5T9W+Sty1LIP 0qD3yobzffiFR61gYw0tfd2SinZ7Kw2FZC7cdnMG9WEBoH/Y5pcuVLEgnDvM3JnNfw XSx6v41BmWm8Q== From: Niklas Cassel To: Shawn Lin , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner Cc: Niklas Cassel , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH RESEND] PCI: rockchip-ep: Mark RK3399 as intx_capable Date: Wed, 16 Apr 2025 16:27:49 +0200 Message-ID: <20250416142749.336298-2-cassel@kernel.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=996; i=cassel@kernel.org; h=from:subject; bh=YohtpSKfziHQfMPNcNaGHRCZ3p7uL5Xf3nCpnAqt2us=; b=owGbwMvMwCV2MsVw8cxjvkWMp9WSGNL/70ud225mUuCSez2hyl9kUt0ZzXSJuU5bvbUc/e4p+ m5J3pXSUcrCIMbFICumyOL7w2V/cbf7lOOKd2xg5rAygQxh4OIUgImIcjAyXP85/0uJXNy7F+y+ N7/ZGe74ESGX+mexQ5i6UlqQWsPFXQx/xabkxhZwKGRsnqK/tufL0ofbH/j//9d5XdhDW+mw7yY LBgA= X-Developer-Key: i=cassel@kernel.org; a=openpgp; fpr=5ADE635C0E631CBBD5BE065A352FE6582ED9B5DA Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250416_072813_216387_E0C89486 X-CRM114-Status: UNSURE ( 8.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RK3399 can raise INTx interrupts, as can be seen by rockchip_pcie_ep_send_intx_irq(). This is also in line with the register description of PCIE_CLIENT_LEGACY_INT_CTRL, section "17.6.3 PCIe Client Detail Register Description" of the RK3399 TRM. Thus, mark RK3399 as intx_capable. Reviewed-by: Manivannan Sadhasivam Signed-off-by: Niklas Cassel --- drivers/pci/controller/pcie-rockchip-ep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c index 85ea36df2f59..626f6b31b0f6 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -694,6 +694,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features = { .linkup_notifier = true, .msi_capable = true, .msix_capable = false, + .intx_capable = true, .align = ROCKCHIP_PCIE_AT_SIZE_ALIGN, }; -- 2.49.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 041DFC369C2 for ; Wed, 16 Apr 2025 15:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Xuw0Nc663Spselbju2Lem686Le4RgrPba7hiUH4rcpA=; b=J8f7r8wxz+1Crs BLbERajiX+4vPEikhH6GaNDarSCSiTnAFGSWFSFJ9c+MQyIXfvj80H/P/CeQys4fI+yuZOI4ELvIg turmmS2nIAhcRNzjzUzI9S3gXrmqLQgSGVegzKkZQ9PVEH0WtMQFf280iz3cvMSE6Gd1IALqi/Y8G CxeuAu8I9x57NoeQjBwKaG1wkbyzIhvaoPC88nmsjHjB/N+GBgwBdAKx4xDHx2mI+SaqmnIoVkMxs 5t+uS+2lXvXkk0tzqx7wnYru1I/rXMKD5J2eA2WVvtpUrcyoaFl/j23/aKdoaUt4XhQ3r4qZ3vEUM EldIFQLk1spo8tDBfw3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u54bk-0000000A3fx-1EHN; Wed, 16 Apr 2025 15:23:24 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u53kL-00000009tPE-0fnB; Wed, 16 Apr 2025 14:28:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 55EAC44BF1; Wed, 16 Apr 2025 14:28:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3340C4AF0D; Wed, 16 Apr 2025 14:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744813692; bh=YohtpSKfziHQfMPNcNaGHRCZ3p7uL5Xf3nCpnAqt2us=; h=From:To:Cc:Subject:Date:From; b=f1gwotxw8qmedNGFyJRw+hTIvIeLRizf3DPhc4hSAPcwnjmnwKmg5oalAo00kvQqv +dpTyPmDKid5E7Mrz7nHDpP+08ZKx3VqELDemHzFHSvYKBt6Ya0zlT+FaiB8kDNNCI JzExyn0z1sT06R9r/aTQps4wyyzGn4FH2zRVMUL2SIFSCnoBsYCqZx7jF/I2MdYgkB x2O0oS+5yGdH16Tj1tMfiuLWxr0pPljQuuXmYNRqK2w+d8517VqI/H5T9W+Sty1LIP 0qD3yobzffiFR61gYw0tfd2SinZ7Kw2FZC7cdnMG9WEBoH/Y5pcuVLEgnDvM3JnNfw XSx6v41BmWm8Q== From: Niklas Cassel To: Shawn Lin , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner Cc: Niklas Cassel , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH RESEND] PCI: rockchip-ep: Mark RK3399 as intx_capable Date: Wed, 16 Apr 2025 16:27:49 +0200 Message-ID: <20250416142749.336298-2-cassel@kernel.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=996; i=cassel@kernel.org; h=from:subject; bh=YohtpSKfziHQfMPNcNaGHRCZ3p7uL5Xf3nCpnAqt2us=; b=owGbwMvMwCV2MsVw8cxjvkWMp9WSGNL/70ud225mUuCSez2hyl9kUt0ZzXSJuU5bvbUc/e4p+ m5J3pXSUcrCIMbFICumyOL7w2V/cbf7lOOKd2xg5rAygQxh4OIUgImIcjAyXP85/0uJXNy7F+y+ N7/ZGe74ESGX+mexQ5i6UlqQWsPFXQx/xabkxhZwKGRsnqK/tufL0ofbH/j//9d5XdhDW+mw7yY LBgA= X-Developer-Key: i=cassel@kernel.org; a=openpgp; fpr=5ADE635C0E631CBBD5BE065A352FE6582ED9B5DA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250416_072813_216387_E0C89486 X-CRM114-Status: UNSURE ( 8.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org RK3399 can raise INTx interrupts, as can be seen by rockchip_pcie_ep_send_intx_irq(). This is also in line with the register description of PCIE_CLIENT_LEGACY_INT_CTRL, section "17.6.3 PCIe Client Detail Register Description" of the RK3399 TRM. Thus, mark RK3399 as intx_capable. Reviewed-by: Manivannan Sadhasivam Signed-off-by: Niklas Cassel --- drivers/pci/controller/pcie-rockchip-ep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c index 85ea36df2f59..626f6b31b0f6 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -694,6 +694,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features = { .linkup_notifier = true, .msi_capable = true, .msix_capable = false, + .intx_capable = true, .align = ROCKCHIP_PCIE_AT_SIZE_ALIGN, }; -- 2.49.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip