Re: [meta-ti] [master/scarthgap][PATCH v1 3/3] bsp: u-boot: deploy tispl_falcon.bin to rootfs

[Denys Dmytriyenko <denis@denix.org>]

On Wed, Apr 16, 2025 at 08:29:13AM +0530, Anshul Dalal wrote:
> On Wed Apr 16, 2025 at 5:41 AM IST, Denys Dmytriyenko wrote:
> > On Tue, Apr 15, 2025 at 03:06:44PM +0530, Anshul Dalal via lists.yoctoproject.org wrote:
> >> Falcon boot requires tispl_falcon.bin to be on the same filesystem
> >> partition as the fitImage.
> >> 
> >> This patch creates a new u-boot package called
> >> 'u-boot-ti-staging-falcon' that is included in IMAGE_INSTALL when
> >> ti-falcon is enabled which allows us to deploy the required files to
> >> rootfs.
> >> 
> >> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> >> ---
> >>  meta-ti-bsp/conf/machine/include/ti-falcon.inc |  1 +
> >>  meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc   | 11 +++++++++++
> >>  2 files changed, 12 insertions(+)
> >> 
> >> diff --git a/meta-ti-bsp/conf/machine/include/ti-falcon.inc b/meta-ti-bsp/conf/machine/include/ti-falcon.inc
> >> index b571c04d..9f93c683 100644
> >> --- a/meta-ti-bsp/conf/machine/include/ti-falcon.inc
> >> +++ b/meta-ti-bsp/conf/machine/include/ti-falcon.inc
> >> @@ -1,3 +1,4 @@
> >> +IMAGE_INSTALL:append = " u-boot-ti-staging-falcon"
> >
> > Why += cannot be used here?
> >
> >
> >>  KERNEL_CLASSES:remove = "kernel-fitimage"
> >>  KERNEL_CLASSES += "kernel-fitimage-legacyhs"
> >>  UBOOT_DTB_LOADADDRESS = "0x82000000"
> >> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> >> index 41d4abdd..76803ae3 100644
> >> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> >> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> >> @@ -14,6 +14,8 @@ require u-boot-mergeconfig.inc
> >>  
> >>  FILESEXTRAPATHS:prepend := "${THISDIR}/u-boot:"
> >>  
> >> +FILES:${PN}-falcon = "boot/tispl_falcon.bin"
> >> +
> >>  SUMMARY = "u-boot bootloader for TI devices"
> >>  
> >>  LICENSE = "GPL-2.0-or-later"
> >> @@ -373,4 +375,13 @@ do_deploy:append:am62pxx() {
> >>  	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${DEPLOYDIR}
> >>  }
> >>  
> >> +do_install:append:ti-falcon() {
> >> +	install -m 0644 ${B}/tispl_falcon.bin ${D}/boot
> >> +}
> >> +
> >> +PACKAGES:prepend:am62xx-evm = "${PN}-falcon "
> >> +PACKAGES:prepend:am62axx-evm = "${PN}-falcon "
> >> +PACKAGES:prepend:am62pxx-evm = "${PN}-falcon "
> >> +PACKAGES:prepend:am62xx-lp-evm = "${PN}-falcon "
> >
> > Shouldn't these be specific to ti-falcon only?
> >
> >
> 
> These are the only supported platforms at the moment, depending on
> machine specific overrides allows us to throw an error at the recipe
> parsing stage instead of having to wait till the do_install task fails
> to copy the non-existent tispl_falcon.bin in case of unsupported
> platforms.

What happens when you build for am62xx-evm and ti-falcon is not enabled?


> As support for more platforms is added, the list can be expanded until
> all platforms are supported when we can just have a ti-falcon override.