From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch,
pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [PATCH net-next 1/4] bnxt_en: Change FW message timeout warning
Date: Wed, 16 Apr 2025 14:44:47 -0700 [thread overview]
Message-ID: <20250416144447.1fde7ada@kernel.org> (raw)
In-Reply-To: <CACKFLi=tvPJXk4zFXxFzWftc-AVU+2m_cg+EFTzs5MSoDoWFaQ@mail.gmail.com>
On Wed, 16 Apr 2025 14:41:10 -0700 Michael Chan wrote:
> On Tue, Apr 15, 2025 at 8:14 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> > sysctl_hung_task_timeout_secs is an exported symbol, and it defaults to 120.
> > Should you not use it in the warning (assuming I understand the intent
> > there)?
> Yes, we have considered that. This is only printed once at driver
> load time, but the sysctl value can be changed at any time after the
> driver is loaded. So we just want to use a reasonable value well
> below the default sysctl_hung_task_timeout_secs value as the
> threshold.
>
> But we can reference and compare with the
> sysctl_hung_task_timeout_secs value if that makes more sense.
I see your point. We could also check against
CONFIG_DEFAULT_HUNG_TASK_TIMEOUT ?
I noticed that some arches set this value really low (10 or 20 sec),
it may be worth warning the users in such cases.
next prev parent reply other threads:[~2025-04-16 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 17:48 [PATCH net-next 0/4] bnxt_en: Update for net-next Michael Chan
2025-04-15 17:48 ` [PATCH net-next 1/4] bnxt_en: Change FW message timeout warning Michael Chan
2025-04-16 3:14 ` Jakub Kicinski
2025-04-16 21:41 ` Michael Chan
2025-04-16 21:44 ` Jakub Kicinski [this message]
2025-04-16 22:07 ` Michael Chan
2025-04-15 17:48 ` [PATCH net-next 2/4] bnxt_en: Report the ethtool coredump length after copying the coredump Michael Chan
2025-04-15 17:48 ` [PATCH net-next 3/4] bnxt_en: Remove unused field "ref_count" in struct bnxt_ulp Michael Chan
2025-04-15 17:48 ` [PATCH net-next 4/4] bnxt_en: Remove unused macros in bnxt_ulp.h Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416144447.1fde7ada@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.