From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 658BCC369C2 for ; Wed, 16 Apr 2025 15:05:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9573182F00; Wed, 16 Apr 2025 17:05:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="GTMIEtCE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D9F8882F10; Wed, 16 Apr 2025 17:05:12 +0200 (CEST) Received: from lelvem-ot01.ext.ti.com (lelvem-ot01.ext.ti.com [198.47.23.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E11F82ED4 for ; Wed, 16 Apr 2025 17:05:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=nm@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelvem-ot01.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 53GF56A82815765 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Apr 2025 10:05:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1744815906; bh=xENr8tCmsJhCV8RVD1TZREuNli1SXKYn50VRGuPnrEI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=GTMIEtCEbfOZkyYybpP3nQZ7VXUUrsZcLtF3vK4NIeUVJzjyhEnSL67biGw+aQp+T hfoxvv5DKelcaox3jETwwFrAmP6s7+OdKZTjRuxCpY5U8h8sPgHc8n5S9hV79loMgl I2IzuaG/XYDTNUj0eVgSQJXA4kLMSHBWtqjpGCHM= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 53GF56jM039844 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 Apr 2025 10:05:06 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 16 Apr 2025 10:05:06 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 16 Apr 2025 10:05:06 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 53GF56ej101830; Wed, 16 Apr 2025 10:05:06 -0500 Date: Wed, 16 Apr 2025 10:05:06 -0500 From: Nishanth Menon To: Anshul Dalal CC: , , , , , , , , Subject: Re: [PATCH v1 0/4] k3: migrate SPL_TEXT_BASE to new address Message-ID: <20250416150506.ws22odswwkjn2wth@deflected> References: <20250416073058.1441001-1-anshuld@ti.com> <20250416112418.nod2fut4v77qlmfq@hummus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 19:18-20250416, Anshul Dalal wrote: > On Wed Apr 16, 2025 at 4:54 PM IST, Nishanth Menon wrote: > > On 13:00-20250416, Anshul Dalal wrote: > >> The change to ATF's PRELOADED_BL33_BASE[1] requires respective changes to > >> SPL_TEXT_BASE on u-boot side. This is necessary to allow the ATF to jump > >> directly to linux kernel (like in falcon mode) which requires a 2MiB aligned > >> load address[2]. The current address ATF jumps to is 0x80080000 which is not > >> 2MiB aligned. > >> > >> Therefore in parallel to the ATF change, this patch set makes the corresponding > >> changes to u-boot. To maintain backwards compatibility with older ATF builds > >> (that still use older address of 0x80080000), the patch set also adds a > >> jump-stub which modifies the execution as follows: > >> > >> Old ATF -> 0x80080000 -> 0x822000000 (Main domain SPL or kernel image) > >> jump stub SPL_TEXT_BASE > >> > >> With the following instructions loaded by the jump-stub: > >> ADDR | Instruction > >> 0x80080000 | mov x15, CONFIG_SPL_TEXT_BASE (0x822000000) > >> 0x80080004 | br x15 > >> > >> Depends on: > >> * [PATCH v3] configs: set SPL_TEXT_BASE by default for k3 platforms > >> https://lore.kernel.org/u-boot/20250415095028.446254-1-anshuld@ti.com/ > >> > >> [1]: > >> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/37447 > >> [2]: > >> "The Image must be placed text_offset bytes from a 2MB aligned base > >> address anywhere in usable system RAM and called there." > >> - Documentation/arch/arm64/booting.rst (linux kernel) > >> > >> Anshul Dalal (4): > >> spl: Kconfig: k3: set SPL_TEXT_BASE to 0x82200000 > >> mach-k3: add a jump stub to support older ATF builds > >> binman: k3: add jump-stub to tispl.bin > >> binman: k3: add jump-stub as loadable > > > > > > How about u-boot documentation? > > I will update that in the next revision along with any feedback I > receive on this patch. IMHO, This change is too intrusive and impacts downstream customers including inflight production devices. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D