From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36E6EC369C2 for ; Thu, 17 Apr 2025 00:13:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D342E409F2; Thu, 17 Apr 2025 00:13:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id bjsGaM9grWq9; Thu, 17 Apr 2025 00:13:16 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5EA1540BE1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1744848796; bh=H3O1/6RUG3DuP7F3e/a1vYh4XqtWkoDastPHR9QLzoc=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IEr2wkgPYKYnySjh4t0O1GC5YLodFI3WvdRZK+zbJewrNoZZOUp5zsiPJ0fzo/mH9 3fCx2U43vPEYke5mMN885v418A8uvT41+tZSavXTbyXEPi8xZEM5lx6S2mm3voK4ay bgzPDEIO12CEkp4Sb0cTsiLcCypbGVHxUzG7bMXfAMMaWF/quh+QilbfBHKLqAabld ytKcDQTDIZEzYQugQHFPOgWe/2jOi8X+H8fexvUosPxkpHvbIN6UiC5W4Ko6tOssqW eZhiVk0FDifkZ5h/V0MloLA7m9jpNEi9uXuJeB0GE0HW6Hy6FHAXA6vrrTSOKsW3ka 3wXgXVofle3cw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 5EA1540BE1; Thu, 17 Apr 2025 00:13:16 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id A976711B for ; Thu, 17 Apr 2025 00:13:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8FCD840BE1 for ; Thu, 17 Apr 2025 00:13:15 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id jhzyxJbbCr9h for ; Thu, 17 Apr 2025 00:13:15 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org EFCE5409F2 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EFCE5409F2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp4.osuosl.org (Postfix) with ESMTPS id EFCE5409F2 for ; Thu, 17 Apr 2025 00:13:14 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id E39FC68429; Thu, 17 Apr 2025 00:12:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DD50C4CEE2; Thu, 17 Apr 2025 00:13:12 +0000 (UTC) Date: Wed, 16 Apr 2025 17:13:11 -0700 From: Jakub Kicinski To: "Keller, Jacob E" Cc: Jaroslav Pulchart , "Kitszel, Przemyslaw" , "Damato, Joe" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "Nguyen, Anthony L" , Igor Raits , Daniel Secik , Zdenek Pesek , "Dumazet, Eric" , Martin Karsten , "Zaki, Ahmed" , "Czapnik, Lukasz" , "Michal Swiatkowski" Message-ID: <20250416171311.30b76ec1@kernel.org> In-Reply-To: References: <4a061a51-8a6c-42b8-9957-66073b4bc65f@intel.com> <20250415175359.3c6117c9@kernel.org> <20250416064852.39fd4b8f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744848792; bh=6SjWXyZeZ7k56pWGMKnGwNYjc5GwbN6XrG18Hplr6Bs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QXEavcoDyiRCE8Oe3BYIEQEl1xn2S9aSNUoBbbG8U05ZfAClSvQL6VG4onUpafULf haqlEocegnyxKjIBG8UPoeoj5uA7sh0zC59OVou3dtKInnna1YIElRgANpJkhGoG3k 1aTG6v5lCaRRb8uQHppNys0+/NE7YTfUckmOJe3+Y8LQgiZIYEcan1W0od3/3xJQrB 3k6NAEQE1HhWhh00zFU+5DKAp/tUWf722blWRQVamKooWOgXpRyWf/TNQ3rqTNvl1d sqTZNdN0E4gA2Yu/yyhFUBA02zunWTlr7RTP2bSdARNaEzjN9q2BpGpYR+1qwunn63 sPm2FM38NMN1A== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QXEavcoD Subject: Re: [Intel-wired-lan] Increased memory usage on NUMA nodes with ICE driver after upgrade to 6.13.y (regression in commit 492a044508ad) X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 16 Apr 2025 22:57:10 +0000 Keller, Jacob E wrote: > > > And you're reverting just and exactly 492a044508ad13 ? > > > The memory for persistent config is allocated in alloc_netdev_mqs() > > > unconditionally. I'm lost as to how this commit could make any > > > difference :( > > > > Yes, reverted the 492a044508ad13. > > Struct napi_config *is* 1056 bytes You're probably looking at 6.15-rcX kernels. Yes, the affinity mask can be large depending on the kernel config. But report is for 6.13, AFAIU. In 6.13 and 6.14 napi_config was tiny.