From: Nathan Chancellor <nathan@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: David Rheinsberg <david@readahead.eu>,
Oleg Nesterov <oleg@redhat.com>,
linux-fsdevel@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Lennart Poettering <lennart@poettering.net>,
Daan De Meyer <daan.j.demeyer@gmail.com>,
Mike Yuan <me@yhndnzj.com>,
linux-kernel@vger.kernel.org,
Peter Ziljstra <peterz@infradead.org>
Subject: Re: [PATCH v2 0/2] pidfs: ensure consistent ENOENT/ESRCH reporting
Date: Wed, 16 Apr 2025 14:15:30 -0700 [thread overview]
Message-ID: <20250416211530.GA3499099@ax162> (raw)
In-Reply-To: <20250416-gegriffen-tiefbau-70cfecb80ac8@brauner>
On Wed, Apr 16, 2025 at 10:21:02PM +0200, Christian Brauner wrote:
> Ok, I think I understand how this happens. dbus-broker assumes that
> only EINVAL is reported by SO_PEERPIDFD when a process is reaped:
>
> https://github.com/bus1/dbus-broker/blob/5d34d91b138fc802a016aa68c093eb81ea31139c/src/util/sockopt.c#L241
>
> It would be great if it would also allow for ESRCH which is the correct
> error code anyway. So hopefully we'll get that fixed in userspace. For
> now we paper over this in the kernel in the SO_PEERPIDFD code.
>
> Can you please test vfs-6.16.pidfs again. It has the patch I'm
> appending.
Yes, that appears to work fine for me, thanks for the quick fix!
If it would be helpful:
Tested-by: Nathan Chancellor <nathan@kernel.org>
Cheers,
Nathan
prev parent reply other threads:[~2025-04-16 21:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 13:22 [PATCH v2 0/2] pidfs: ensure consistent ENOENT/ESRCH reporting Christian Brauner
2025-04-11 13:22 ` [PATCH v2 1/2] exit: move wake_up_all() pidfd waiters into __unhash_process() Christian Brauner
2025-04-11 13:22 ` [PATCH v2 2/2] pidfs: ensure consistent ENOENT/ESRCH reporting Christian Brauner
2025-04-11 13:54 ` Oleg Nesterov
2025-04-11 15:14 ` Christian Brauner
2025-04-11 15:28 ` Oleg Nesterov
2025-04-15 22:34 ` [PATCH v2 0/2] " Nathan Chancellor
2025-04-16 13:55 ` Christian Brauner
2025-04-16 19:47 ` Christian Brauner
2025-04-16 20:21 ` Christian Brauner
2025-04-16 21:15 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416211530.GA3499099@ax162 \
--to=nathan@kernel.org \
--cc=brauner@kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=david@readahead.eu \
--cc=jlayton@kernel.org \
--cc=lennart@poettering.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@yhndnzj.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.