From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, ming.lei@redhat.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] loop: fix min directio size detection for nested loop devices
Date: Thu, 17 Apr 2025 08:25:27 +0200 [thread overview]
Message-ID: <20250417062527.GA22173@lst.de> (raw)
In-Reply-To: <20250417034639.GG25659@frogsfrogsfrogs>
On Wed, Apr 16, 2025 at 08:46:39PM -0700, Darrick J. Wong wrote:
> If however SCRATCH_DEV is itself a loop device that we've used to
> simulate 4k LBA block devices, the minimum directio size discovery
> introduced in commit f4774e92aab85d is wrong -- we should query the
> logical block size of the underlying block device because file->f_path
> points whatever filesystem /dev is.
No, the problem is that special handling of block devices in stat
sits in vfs_statx_path and not the exported vfs_getattr helper,
and thus we don't call into bdev_statx which would return the right
value. I'll send a separate VFS-level fix for this.
prev parent reply other threads:[~2025-04-17 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 3:46 [PATCH] loop: fix min directio size detection for nested loop devices Darrick J. Wong
2025-04-17 6:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417062527.GA22173@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.