Re: [PATCH v2 09/13] vt: support Unicode recomposition

[kernel test robot <lkp@intel.com>]

Hi Nicolas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tty/tty-linus]
[also build test WARNING on linus/master v6.15-rc2]
[cannot apply to tty/tty-testing tty/tty-next next-20250416]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nicolas-Pitre/vt-minor-cleanup-to-vc_translate_unicode/20250416-142136
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-linus
patch link:    https://lore.kernel.org/r/20250415192212.33949-10-nico%40fluxnic.net
patch subject: [PATCH v2 09/13] vt: support Unicode recomposition
config: arc-randconfig-002-20250417 (https://download.01.org/0day-ci/archive/20250417/202504171730.edWXWP53-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250417/202504171730.edWXWP53-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504171730.edWXWP53-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/tty/vt/ucs.c:43: warning: Function parameter or struct member 'cp' not described in 'ucs_is_zero_width'
   drivers/tty/vt/ucs.c:43: warning: expecting prototype for Determine if a Unicode code point is zero(). Prototype was for ucs_is_zero_width() instead
   drivers/tty/vt/ucs.c:55: warning: Function parameter or struct member 'cp' not described in 'ucs_is_double_width'
   drivers/tty/vt/ucs.c:55: warning: expecting prototype for Determine if a Unicode code point is double(). Prototype was for ucs_is_double_width() instead
>> drivers/tty/vt/ucs.c:99: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Attempt to recompose two Unicode characters into a single character.


vim +99 drivers/tty/vt/ucs.c

    35	
    36	/**
    37	 * Determine if a Unicode code point is zero-width.
    38	 *
    39	 * @param cp: Unicode code point (UCS-4)
    40	 * Return: true if the character is zero-width, false otherwise
    41	 */
    42	bool ucs_is_zero_width(u32 cp)
  > 43	{
    44		return cp_in_range(cp, ucs_zero_width_ranges,
    45				   ARRAY_SIZE(ucs_zero_width_ranges));
    46	}
    47	
    48	/**
    49	 * Determine if a Unicode code point is double-width.
    50	 *
    51	 * @param cp: Unicode code point (UCS-4)
    52	 * Return: true if the character is double-width, false otherwise
    53	 */
    54	bool ucs_is_double_width(u32 cp)
    55	{
    56		return cp_in_range(cp, ucs_double_width_ranges,
    57				   ARRAY_SIZE(ucs_double_width_ranges));
    58	}
    59	
    60	/*
    61	 * Structure for base with combining mark pairs and resulting recompositions.
    62	 * Using u16 to save space since all values are within BMP range.
    63	 */
    64	struct ucs_recomposition {
    65		u16 base;	/* base character */
    66		u16 mark;	/* combining mark */
    67		u16 recomposed;	/* corresponding recomposed character */
    68	};
    69	
    70	#include "ucs_recompose_table.h"
    71	
    72	struct compare_key {
    73		u16 base;
    74		u16 mark;
    75	};
    76	
    77	static int recomposition_cmp(const void *key, const void *element)
    78	{
    79		const struct compare_key *search_key = key;
    80		const struct ucs_recomposition *entry = element;
    81	
    82		/* Compare base character first */
    83		if (search_key->base < entry->base)
    84			return -1;
    85		if (search_key->base > entry->base)
    86			return 1;
    87	
    88		/* Base characters match, now compare combining character */
    89		if (search_key->mark < entry->mark)
    90			return -1;
    91		if (search_key->mark > entry->mark)
    92			return 1;
    93	
    94		/* Both match */
    95		return 0;
    96	}
    97	
    98	/**
  > 99	 * Attempt to recompose two Unicode characters into a single character.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki