From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C04D1D07BA; Thu, 17 Apr 2025 18:24:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744914273; cv=none; b=o7/iaC0J5bwK/PxJoA2DRotGOUpBQWInKoZYkjK2zVCtwLv6f3NQfJjvRSE7ZeFvMcjHWoLWQgTlEAn+HsUnbr5C0rGZHIJ1GHWyJ3zmw+NZuGf3JgnSCJ7m1nTjOpoUA1JEXU000wGBJW+VzMdOiH7c3WlWcCNDu+2Knrq3v9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744914273; c=relaxed/simple; bh=xZ+GyDP7WQjkjgy5n/swff9+Bx0TuJj4M9yQON5DbGI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GMO8HHkrR2wbGQQVUjTf7hX+44yrr4j3+qcvfa0N4TFID/9SkzvktMl+J+c/JYyrQAS6T4VdaOSnapwmH3QfFUlg6BV0WK4RON4pTKKM3kGLz9JomcVGcYGO81bgd5VGqLe+GfdbRVs3EW2P9IXeIFP4Edx1K2Cu2Bmg3EHBcik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=y/zQX0a8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="y/zQX0a8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17FD9C4CEE4; Thu, 17 Apr 2025 18:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744914273; bh=xZ+GyDP7WQjkjgy5n/swff9+Bx0TuJj4M9yQON5DbGI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y/zQX0a8PBqsCja1XIEEQM51s27L9mMQEOHWrcw79R/LRyR4aCLAC0/SFieP2A/XO lirUgT57wbPuT2yKuGy+HqUv61d78o2zSRZ0SNRrKyK6XerH5Bg2jX1F/KLqvvVZ2G G5BqgXgJjferfHolR+P+gwzpX2anzMTsOhn7bnMI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rodrigo Vivi , Lucas De Marchi , Sasha Levin Subject: [PATCH 6.13 145/414] drivers: base: devres: Allow to release group on device release Date: Thu, 17 Apr 2025 19:48:23 +0200 Message-ID: <20250417175117.258210988@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250417175111.386381660@linuxfoundation.org> References: <20250417175111.386381660@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lucas De Marchi [ Upstream commit 8e1ddfada4530939a8cb64ee9251aef780474274 ] When releasing a device, if the release action causes a group to be released, a warning is emitted because it can't find the group. This happens because devres_release_all() moves the entire list to a todo list and also move the group markers. Considering r* normal resource nodes and g1 a group resource node: g1 -----------. v v r1 -> r2 -> g1[0] -> r3-> g[1] -> r4 After devres_release_all(), dev->devres_head becomes empty and the todo list it iterates on becomes: g1 v r1 -> r2 -> r3-> r4 -> g1[0] When a call to component_del() is made and takes down the aggregate device, a warning like this happen: RIP: 0010:devres_release_group+0x362/0x530 ... Call Trace: component_unbind+0x156/0x380 component_unbind_all+0x1d0/0x270 mei_component_master_unbind+0x28/0x80 [mei_hdcp] take_down_aggregate_device+0xc1/0x160 component_del+0x1c6/0x3e0 intel_hdcp_component_fini+0xf1/0x170 [xe] xe_display_fini+0x1e/0x40 [xe] Because the devres group corresponding to the hdcp component cannot be found. Just ignore this corner case: if the dev->devres_head is empty and the caller is trying to remove a group, it's likely in the process of device cleanup so just ignore it instead of warning. Acked-by: Greg Kroah-Hartman Reviewed-by: Rodrigo Vivi Link: https://patchwork.freedesktop.org/patch/msgid/20250222001051.3012936-2-lucas.demarchi@intel.com Signed-off-by: Lucas De Marchi Signed-off-by: Sasha Levin --- drivers/base/devres.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/base/devres.c b/drivers/base/devres.c index 2152eec0c1352..68224f2f83fff 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -687,6 +687,13 @@ int devres_release_group(struct device *dev, void *id) spin_unlock_irqrestore(&dev->devres_lock, flags); release_nodes(dev, &todo); + } else if (list_empty(&dev->devres_head)) { + /* + * dev is probably dying via devres_release_all(): groups + * have already been removed and are on the process of + * being released - don't touch and don't warn. + */ + spin_unlock_irqrestore(&dev->devres_lock, flags); } else { WARN_ON(1); spin_unlock_irqrestore(&dev->devres_lock, flags); -- 2.39.5