From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD6E25FA2C; Thu, 17 Apr 2025 18:31:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744914661; cv=none; b=ov13W3fj5GWngXUutsKdeTEhHU7Rl9aYK+CbGihleHczgmfNwzPkna9eF8j8oGzVWfPbd5J72ZwP6P3idQUOuCC3E437saRkg12BhFvb053+tTMjaztTGFOwISzrepWX48Fu7Yoj8ULxIqZsLH/+JlAfkDMhsrK7rqK3m0YktiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744914661; c=relaxed/simple; bh=MQKEtpkZy+Tgp9C1AsIFWiHti2pTN6g/G03DsgM7iMM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WGXinaQ0K6UGpWw44FzNf1D5wFRbLk7aakdeS23RP/O/TZdUoVNSB0kbgZiZkS2av6KpkjM0eBiWPtkkcRcJCFJ1jdtZW/zDtEnk5vnFSW/2muI8MgXJ78GU3mrhMTVI7YQA9uybeapDpsVW/oOBXwFWOeYYbMFFerbxdKKpOsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J/WtOwjs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J/WtOwjs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A73DEC4CEE4; Thu, 17 Apr 2025 18:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744914661; bh=MQKEtpkZy+Tgp9C1AsIFWiHti2pTN6g/G03DsgM7iMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J/WtOwjscHuEQGW87+AuZdeMuVn5sV7nugiVpXdiq3qVucA8kLq/XfRsbgQHOrP+R EQO6ZffhemzaHbXzsbZMuuJFXTmAmrg2Qt46v0kAqgNyJZz1C/O+6j2iYhW4IZdswC IcELfcNFWX7FoHdqRu+GybVyssYc4LBrVE8xDhSA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jan Kara , Zhang Yi , Theodore Tso Subject: [PATCH 6.13 290/414] jbd2: remove wrong sb->s_sequence check Date: Thu, 17 Apr 2025 19:50:48 +0200 Message-ID: <20250417175123.090871897@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250417175111.386381660@linuxfoundation.org> References: <20250417175111.386381660@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jan Kara commit e6eff39dd0fe4190c6146069cc16d160e71d1148 upstream. Journal emptiness is not determined by sb->s_sequence == 0 but rather by sb->s_start == 0 (which is set a few lines above). Furthermore 0 is a valid transaction ID so the check can spuriously trigger. Remove the invalid WARN_ON. CC: stable@vger.kernel.org Signed-off-by: Jan Kara Reviewed-by: Zhang Yi Link: https://patch.msgid.link/20250206094657.20865-3-jack@suse.cz Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/jbd2/journal.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -1879,7 +1879,6 @@ int jbd2_journal_update_sb_log_tail(jour /* Log is no longer empty */ write_lock(&journal->j_state_lock); - WARN_ON(!sb->s_sequence); journal->j_flags &= ~JBD2_FLUSHED; write_unlock(&journal->j_state_lock);