All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Anshul Dalal <anshuld@ti.com>
Cc: u-boot@lists.denx.de, vigneshr@ti.com, nm@ti.com
Subject: Re: [PATCH v7 1/4] spl: remove usage of CMD_BOOTx from image parsing
Date: Thu, 17 Apr 2025 14:58:33 -0600	[thread overview]
Message-ID: <20250417205833.GA3017152@bill-the-cat> (raw)
In-Reply-To: <20250408141436.712387-1-anshuld@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Tue, Apr 08, 2025 at 07:44:30PM +0530, Anshul Dalal wrote:

> Using CMD_* configs from spl doesn't make logical sense. Therefore this
> patch replaces the checks for CMD_BOOTx with newly added library symbols
> BOOTI, BOOTM and BOOTZ which are enabled by their respective CMD_* or
> SPL_* counterparts.
> 
> SPL_BOOTZ is enabled by default for 32-bit ARM systems and SPL_BOOTI is
> enabled by default for 64-bit ARM and RISCV.
> 
> The respective C files (image.c/zimage.c) are compiled based on library
> symbols BOOTx instead which are in turn selected by both CMD_BOOTx and
> SPL_BOOTx as required.
> 
> Signed-off-by: Anshul Dalal <anshuld@ti.com>

So, for the series, we have a few problems, still. First, this is still
not size neutral as we now end up dropping bootz from a few 32bit
platforms (gwventana_nand, display5, gwventana_emmc, display5_factory)
and growing colibri_vf. Next and more importantly, as after Nishanth's
explanation, TF-A isn't going to support this case either, I believe
it's best to just drop this part of the support as well. Thanks for the
effort all the same.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  parent reply	other threads:[~2025-04-17 20:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 14:14 [PATCH v7 1/4] spl: remove usage of CMD_BOOTx from image parsing Anshul Dalal
2025-04-08 14:14 ` [PATCH v7 2/4] configs: disable SPL_BOOTZ to preserve spl size Anshul Dalal
2025-04-08 14:14 ` [PATCH v7 3/4] configs: migrate falcon configs to SPL_BOOTx Anshul Dalal
2025-04-08 14:14 ` [PATCH v7 4/4] configs: colibri_vf: set CMD_BOOTM Anshul Dalal
2025-04-17 20:58 ` Tom Rini [this message]
2025-04-17 21:37   ` [PATCH v7 1/4] spl: remove usage of CMD_BOOTx from image parsing Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250417205833.GA3017152@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=anshuld@ti.com \
    --cc=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.